Commit c1ae8f3a authored by Al Viro's avatar Al Viro Committed by Mauro Carvalho Chehab

[media] davinci: ccdc_update_raw_params() frees the wrong thing

Passing a physical address to free_pages() is a bad idea.
config_params->fault_pxl.fpc_table_addr is set to virt_to_phys()
of __get_free_pages() return value; what we should pass to free_pages()
is its phys_to_virt().  ccdc_close() does that properly, but
ccdc_update_raw_params() doesn't.
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Acked-by: default avatarLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 47de9bf8
...@@ -261,7 +261,7 @@ static int ccdc_update_raw_params(struct ccdc_config_params_raw *raw_params) ...@@ -261,7 +261,7 @@ static int ccdc_update_raw_params(struct ccdc_config_params_raw *raw_params)
*/ */
if (raw_params->fault_pxl.fp_num != config_params->fault_pxl.fp_num) { if (raw_params->fault_pxl.fp_num != config_params->fault_pxl.fp_num) {
if (fpc_physaddr != NULL) { if (fpc_physaddr != NULL) {
free_pages((unsigned long)fpc_physaddr, free_pages((unsigned long)fpc_virtaddr,
get_order get_order
(config_params->fault_pxl.fp_num * (config_params->fault_pxl.fp_num *
FP_NUM_BYTES)); FP_NUM_BYTES));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment