Commit c214909b authored by Gui Jianfeng's avatar Gui Jianfeng Committed by Arnaldo Carvalho de Melo

perf tools: Fix find tids routine by excluding "." and ".."

Introduce a filter function to skip "." and ".." directories when calculating
tid number, otherwise tid 0 will be included in the all_tid result array.

Cc: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <4C185F68.1020505@cn.fujitsu.com>
Signed-off-by: default avatarGui Jianfeng <guijianfeng@cn.fujitsu.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent a1e80faf
...@@ -7,6 +7,15 @@ ...@@ -7,6 +7,15 @@
#include "util.h" #include "util.h"
#include "debug.h" #include "debug.h"
/* Skip "." and ".." directories */
static int filter(const struct dirent *dir)
{
if (dir->d_name[0] == '.')
return 0;
else
return 1;
}
int find_all_tid(int pid, pid_t ** all_tid) int find_all_tid(int pid, pid_t ** all_tid)
{ {
char name[256]; char name[256];
...@@ -16,7 +25,7 @@ int find_all_tid(int pid, pid_t ** all_tid) ...@@ -16,7 +25,7 @@ int find_all_tid(int pid, pid_t ** all_tid)
int i; int i;
sprintf(name, "/proc/%d/task", pid); sprintf(name, "/proc/%d/task", pid);
items = scandir(name, &namelist, NULL, NULL); items = scandir(name, &namelist, filter, NULL);
if (items <= 0) if (items <= 0)
return -ENOENT; return -ENOENT;
*all_tid = malloc(sizeof(pid_t) * items); *all_tid = malloc(sizeof(pid_t) * items);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment