Commit c21ab2af authored by Mike Pattrick's avatar Mike Pattrick Committed by David S. Miller

openvswitch: Fix overreporting of drops in dropwatch

Currently queue_userspace_packet will call kfree_skb for all frames,
whether or not an error occurred. This can result in a single dropped
frame being reported as multiple drops in dropwatch. This functions
caller may also call kfree_skb in case of an error. This patch will
consume the skbs instead and allow caller's to use kfree_skb.
Signed-off-by: default avatarMike Pattrick <mkp@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2109957Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1100248a
...@@ -558,8 +558,9 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, ...@@ -558,8 +558,9 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb,
out: out:
if (err) if (err)
skb_tx_error(skb); skb_tx_error(skb);
kfree_skb(user_skb); consume_skb(user_skb);
kfree_skb(nskb); consume_skb(nskb);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment