Commit c2a09f3d authored by Ritesh Harjani (IBM)'s avatar Ritesh Harjani (IBM) Committed by Theodore Ts'o

ext4: Fixes len calculation in mpage_journal_page_buffers

Truncate operation can race with writeback, in which inode->i_size can get
truncated and therefore size - folio_pos() can be negative. This fixes the
len calculation. However this path doesn't get easily triggered even
with data journaling.

Cc: stable@kernel.org # v6.5
Fixes: 80be8c5c ("Fixes: ext4: Make mpage_journal_page_buffers use folio")
Signed-off-by: default avatarRitesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/cff4953b5c9306aba71e944ab176a5d396b9a1b7.1709182250.git.ritesh.list@gmail.comSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 0bbac3fa
...@@ -2334,7 +2334,7 @@ static int mpage_journal_page_buffers(handle_t *handle, ...@@ -2334,7 +2334,7 @@ static int mpage_journal_page_buffers(handle_t *handle,
if (folio_pos(folio) + len > size && if (folio_pos(folio) + len > size &&
!ext4_verity_in_progress(inode)) !ext4_verity_in_progress(inode))
len = size - folio_pos(folio); len = size & (len - 1);
return ext4_journal_folio_buffers(handle, folio, len); return ext4_journal_folio_buffers(handle, folio, len);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment