Commit c2c7af9c authored by Sifan Naeem's avatar Sifan Naeem Committed by Sasha Levin

[media] rc: img-ir: fix error in parameters passed to irq_free()

[ Upstream commit 80ccf4ad ]

img_ir_remove() passes a pointer to the ISR function as the 2nd
parameter to irq_free() instead of a pointer to the device data
structure.
This issue causes unloading img-ir module to fail with the below
warning after building and loading img-ir as a module.

WARNING: CPU: 2 PID: 155 at ../kernel/irq/manage.c:1278
__free_irq+0xb4/0x214() Trying to free already-free IRQ 58
Modules linked in: img_ir(-)
CPU: 2 PID: 155 Comm: rmmod Not tainted 3.14.0 #55 ...
Call Trace:
...
[<8048d420>] __free_irq+0xb4/0x214
[<8048d6b4>] free_irq+0xac/0xf4
[<c009b130>] img_ir_remove+0x54/0xd4 [img_ir] [<8073ded0>]
platform_drv_remove+0x30/0x54 ...

Fixes: 160a8f8a ("[media] rc: img-ir: add base driver")
Signed-off-by: default avatarSifan Naeem <sifan.naeem@imgtec.com>
Cc: <stable@vger.kernel.org> # 3.15+
Acked-by: default avatarJames Hogan <james.hogan@imgtec.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent 3b2b5bee
...@@ -146,7 +146,7 @@ static int img_ir_remove(struct platform_device *pdev) ...@@ -146,7 +146,7 @@ static int img_ir_remove(struct platform_device *pdev)
{ {
struct img_ir_priv *priv = platform_get_drvdata(pdev); struct img_ir_priv *priv = platform_get_drvdata(pdev);
free_irq(priv->irq, img_ir_isr); free_irq(priv->irq, priv);
img_ir_remove_hw(priv); img_ir_remove_hw(priv);
img_ir_remove_raw(priv); img_ir_remove_raw(priv);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment