Commit c31799ba authored by Sven Van Asbroeck's avatar Sven Van Asbroeck Committed by Jakub Kicinski

lan743x: clean up software_isr function

For no apparent reason, this function reads the INT_STS register, and
checks if the software interrupt bit is set. These things have already
been carried out by this function's only caller.

Clean up by removing the redundant code.

Tested-by: Sven Van Asbroeck <thesven73@gmail.com> # lan7430
Signed-off-by: default avatarSven Van Asbroeck <thesven73@gmail.com>
Link: https://lore.kernel.org/r/20201123191529.14908-1-TheSven73@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent da43f0aa
......@@ -140,18 +140,13 @@ static int lan743x_csr_init(struct lan743x_adapter *adapter)
return result;
}
static void lan743x_intr_software_isr(void *context)
static void lan743x_intr_software_isr(struct lan743x_adapter *adapter)
{
struct lan743x_adapter *adapter = context;
struct lan743x_intr *intr = &adapter->intr;
u32 int_sts;
int_sts = lan743x_csr_read(adapter, INT_STS);
if (int_sts & INT_BIT_SW_GP_) {
/* disable the interrupt to prevent repeated re-triggering */
lan743x_csr_write(adapter, INT_EN_CLR, INT_BIT_SW_GP_);
intr->software_isr_flag = 1;
}
/* disable the interrupt to prevent repeated re-triggering */
lan743x_csr_write(adapter, INT_EN_CLR, INT_BIT_SW_GP_);
intr->software_isr_flag = 1;
}
static void lan743x_tx_isr(void *context, u32 int_sts, u32 flags)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment