Commit c3f6ddfe authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

media: mx2-emmaprp: constify v4l2_m2m_ops structures

The v4l2_m2m_ops structures are only passed as the only
argument to v4l2_m2m_init, which is declared as const.
Thus the v4l2_m2m_ops structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct v4l2_m2m_ops i@p = { ... };

@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)

@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct v4l2_m2m_ops i = { ... };
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 92afad2d
...@@ -882,7 +882,7 @@ static struct video_device emmaprp_videodev = { ...@@ -882,7 +882,7 @@ static struct video_device emmaprp_videodev = {
.vfl_dir = VFL_DIR_M2M, .vfl_dir = VFL_DIR_M2M,
}; };
static struct v4l2_m2m_ops m2m_ops = { static const struct v4l2_m2m_ops m2m_ops = {
.device_run = emmaprp_device_run, .device_run = emmaprp_device_run,
.job_abort = emmaprp_job_abort, .job_abort = emmaprp_job_abort,
.lock = emmaprp_lock, .lock = emmaprp_lock,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment