[PATCH] add MODULE_VERSION to drivers/scsi

On Thu, Jul 22, 2004 at 01:28:23PM +0100, Matthew Wilcox wrote:
> > +#define SYM_VERSION "2.1.18j"
> > +#define SYM_DRIVER_NAME	"sym-" SYM_VERSION
>
> Umm.  No.  This is ridiculous.  I'm not having a 51 line copyright message
> with 2 lines of #define.  It's not even clear to me that these two lines
> have artisitic merit.  How about putting these defines in sym_defs.h,
> at the top?  It's already included in both sym_glue.c and sym_hipd.c by
> being included by sym_glue.h.

Indeed, point well taken.  Done, they're now at the top of defines in
sym_defs.h, and I've updated my BK tree accordingly.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

drivers/scsi/sym53c8xx_2/sym_defs.h

@@ -53,6 +53,9 @@
 #ifndef SYM_DEFS_H
 #define SYM_DEFS_H
 
+#define SYM_VERSION "2.1.18j"
+#define SYM_DRIVER_NAME	"sym-" SYM_VERSION
+
 /*
  *  Vendor.
  */

drivers/scsi/sym53c8xx_2/sym_glue.c

@@ -2283,6 +2283,7 @@ static int sym_detach(struct sym_hcb *np)
 }
 
 MODULE_LICENSE("Dual BSD/GPL");
+MODULE_VERSION(SYM_VERSION);
 
 /*
  * Driver host template.

drivers/scsi/sym53c8xx_2/sym_hipd.c

@@ -49,10 +49,6 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
-
-#define SYM_VERSION "2.1.18j"
-#define SYM_DRIVER_NAME	"sym-" SYM_VERSION
-
 #include "sym_glue.h"
 #include "sym_nvram.h"