Commit c45361a1 authored by Henrik Rydberg's avatar Henrik Rydberg

Revert "Input: atmel_mxt_ts - warn if sysfs could not be created"

Dmitry: I understand that I am a bit late to the party :) but I do not
agree with this change. Failure to create attributes is not sometihng
that user could cause (at least not easily) and thus would not be a
setup issue but something more severe. I believe we should fail
loading the driver so sysfs attribute breakage will be noticed as soon
as possible, instead of discovering it much much later in the process.

This reverts commit 63990038.
Requested-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarHenrik Rydberg <rydberg@euromail.se>
parent cab7faca
...@@ -1184,10 +1184,13 @@ static int __devinit mxt_probe(struct i2c_client *client, ...@@ -1184,10 +1184,13 @@ static int __devinit mxt_probe(struct i2c_client *client,
error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group); error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
if (error) if (error)
dev_warn(&client->dev, "error creating sysfs entries.\n"); goto err_unregister_device;
return 0; return 0;
err_unregister_device:
input_unregister_device(input_dev);
input_dev = NULL;
err_free_irq: err_free_irq:
free_irq(client->irq, data); free_irq(client->irq, data);
err_free_object: err_free_object:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment