Commit c547630f authored by Firo Yang's avatar Firo Yang Committed by Greg Kroah-Hartman

ARM: meson: serial: convert iounmap to devm_iounmap

The function meson_uart_release_port() inappropriately try to
iounmap() a resource managed by devm_ioremap_nocache().
The function meson_uart_release_port() maybe called by uart_ioctl()
that means meson_uart_release_port() is not called from within a
probe or remove function, for safety, I convert iounmap() to
devm_iounmap().
Signed-off-by: default avatarFiro Yang <firogm@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eda0cd35
...@@ -370,7 +370,7 @@ static int meson_uart_verify_port(struct uart_port *port, ...@@ -370,7 +370,7 @@ static int meson_uart_verify_port(struct uart_port *port,
static void meson_uart_release_port(struct uart_port *port) static void meson_uart_release_port(struct uart_port *port)
{ {
if (port->flags & UPF_IOREMAP) { if (port->flags & UPF_IOREMAP) {
iounmap(port->membase); devm_iounmap(port->dev, port->membase);
port->membase = NULL; port->membase = NULL;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment