Commit c551858a authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Anna Schumaker

sunrpc: move p_count out of struct rpc_procinfo

p_count is the only writeable memeber of struct rpc_procinfo, which is
a good candidate to be const-ified as it contains function pointers.

This patch moves it into out out struct rpc_procinfo, and into a
separate writable array that is pointed to by struct rpc_version and
indexed by p_statidx.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent e91ff8e3
...@@ -602,8 +602,10 @@ static struct rpc_procinfo nlm4_procedures[] = { ...@@ -602,8 +602,10 @@ static struct rpc_procinfo nlm4_procedures[] = {
PROC(GRANTED_RES, res, norep), PROC(GRANTED_RES, res, norep),
}; };
static unsigned int nlm_version4_counts[ARRAY_SIZE(nlm4_procedures)];
const struct rpc_version nlm_version4 = { const struct rpc_version nlm_version4 = {
.number = 4, .number = 4,
.nrprocs = ARRAY_SIZE(nlm4_procedures), .nrprocs = ARRAY_SIZE(nlm4_procedures),
.procs = nlm4_procedures, .procs = nlm4_procedures,
.counts = nlm_version4_counts,
}; };
...@@ -600,16 +600,20 @@ static struct rpc_procinfo nlm_procedures[] = { ...@@ -600,16 +600,20 @@ static struct rpc_procinfo nlm_procedures[] = {
PROC(GRANTED_RES, res, norep), PROC(GRANTED_RES, res, norep),
}; };
static unsigned int nlm_version1_counts[ARRAY_SIZE(nlm_procedures)];
static const struct rpc_version nlm_version1 = { static const struct rpc_version nlm_version1 = {
.number = 1, .number = 1,
.nrprocs = ARRAY_SIZE(nlm_procedures), .nrprocs = ARRAY_SIZE(nlm_procedures),
.procs = nlm_procedures, .procs = nlm_procedures,
.counts = nlm_version1_counts,
}; };
static unsigned int nlm_version3_counts[ARRAY_SIZE(nlm_procedures)];
static const struct rpc_version nlm_version3 = { static const struct rpc_version nlm_version3 = {
.number = 3, .number = 3,
.nrprocs = ARRAY_SIZE(nlm_procedures), .nrprocs = ARRAY_SIZE(nlm_procedures),
.procs = nlm_procedures, .procs = nlm_procedures,
.counts = nlm_version3_counts,
}; };
static const struct rpc_version *nlm_versions[] = { static const struct rpc_version *nlm_versions[] = {
......
...@@ -552,10 +552,12 @@ static struct rpc_procinfo nsm_procedures[] = { ...@@ -552,10 +552,12 @@ static struct rpc_procinfo nsm_procedures[] = {
}, },
}; };
static unsigned int nsm_version1_counts[ARRAY_SIZE(nsm_procedures)];
static const struct rpc_version nsm_version1 = { static const struct rpc_version nsm_version1 = {
.number = 1, .number = 1,
.nrprocs = ARRAY_SIZE(nsm_procedures), .nrprocs = ARRAY_SIZE(nsm_procedures),
.procs = nsm_procedures .procs = nsm_procedures,
.counts = nsm_version1_counts,
}; };
static const struct rpc_version *nsm_version[] = { static const struct rpc_version *nsm_version[] = {
......
...@@ -504,17 +504,20 @@ static struct rpc_procinfo mnt3_procedures[] = { ...@@ -504,17 +504,20 @@ static struct rpc_procinfo mnt3_procedures[] = {
}, },
}; };
static unsigned int mnt_counts[ARRAY_SIZE(mnt_procedures)];
static const struct rpc_version mnt_version1 = { static const struct rpc_version mnt_version1 = {
.number = 1, .number = 1,
.nrprocs = ARRAY_SIZE(mnt_procedures), .nrprocs = ARRAY_SIZE(mnt_procedures),
.procs = mnt_procedures, .procs = mnt_procedures,
.counts = mnt_counts,
}; };
static unsigned int mnt3_counts[ARRAY_SIZE(mnt_procedures)];
static const struct rpc_version mnt_version3 = { static const struct rpc_version mnt_version3 = {
.number = 3, .number = 3,
.nrprocs = ARRAY_SIZE(mnt3_procedures), .nrprocs = ARRAY_SIZE(mnt3_procedures),
.procs = mnt3_procedures, .procs = mnt3_procedures,
.counts = mnt3_counts,
}; };
static const struct rpc_version *mnt_version[] = { static const struct rpc_version *mnt_version[] = {
......
...@@ -1170,8 +1170,10 @@ struct rpc_procinfo nfs_procedures[] = { ...@@ -1170,8 +1170,10 @@ struct rpc_procinfo nfs_procedures[] = {
PROC(STATFS, fhandle, statfsres, 0), PROC(STATFS, fhandle, statfsres, 0),
}; };
static unsigned int nfs_version2_counts[ARRAY_SIZE(nfs_procedures)];
const struct rpc_version nfs_version2 = { const struct rpc_version nfs_version2 = {
.number = 2, .number = 2,
.nrprocs = ARRAY_SIZE(nfs_procedures), .nrprocs = ARRAY_SIZE(nfs_procedures),
.procs = nfs_procedures .procs = nfs_procedures,
.counts = nfs_version2_counts,
}; };
...@@ -2578,10 +2578,12 @@ struct rpc_procinfo nfs3_procedures[] = { ...@@ -2578,10 +2578,12 @@ struct rpc_procinfo nfs3_procedures[] = {
PROC(COMMIT, commit, commit, 5), PROC(COMMIT, commit, commit, 5),
}; };
static unsigned int nfs_version3_counts[ARRAY_SIZE(nfs3_procedures)];
const struct rpc_version nfs_version3 = { const struct rpc_version nfs_version3 = {
.number = 3, .number = 3,
.nrprocs = ARRAY_SIZE(nfs3_procedures), .nrprocs = ARRAY_SIZE(nfs3_procedures),
.procs = nfs3_procedures .procs = nfs3_procedures,
.counts = nfs_version3_counts,
}; };
#ifdef CONFIG_NFS_V3_ACL #ifdef CONFIG_NFS_V3_ACL
...@@ -2606,10 +2608,12 @@ static struct rpc_procinfo nfs3_acl_procedures[] = { ...@@ -2606,10 +2608,12 @@ static struct rpc_procinfo nfs3_acl_procedures[] = {
}, },
}; };
static unsigned int nfs3_acl_counts[ARRAY_SIZE(nfs3_acl_procedures)];
const struct rpc_version nfsacl_version3 = { const struct rpc_version nfsacl_version3 = {
.number = 3, .number = 3,
.nrprocs = sizeof(nfs3_acl_procedures)/ .nrprocs = sizeof(nfs3_acl_procedures)/
sizeof(nfs3_acl_procedures[0]), sizeof(nfs3_acl_procedures[0]),
.procs = nfs3_acl_procedures, .procs = nfs3_acl_procedures,
.counts = nfs3_acl_counts,
}; };
#endif /* CONFIG_NFS_V3_ACL */ #endif /* CONFIG_NFS_V3_ACL */
...@@ -7661,10 +7661,12 @@ struct rpc_procinfo nfs4_procedures[] = { ...@@ -7661,10 +7661,12 @@ struct rpc_procinfo nfs4_procedures[] = {
#endif /* CONFIG_NFS_V4_2 */ #endif /* CONFIG_NFS_V4_2 */
}; };
static unsigned int nfs_version4_counts[ARRAY_SIZE(nfs4_procedures)];
const struct rpc_version nfs_version4 = { const struct rpc_version nfs_version4 = {
.number = 4, .number = 4,
.nrprocs = ARRAY_SIZE(nfs4_procedures), .nrprocs = ARRAY_SIZE(nfs4_procedures),
.procs = nfs4_procedures .procs = nfs4_procedures,
.counts = nfs_version4_counts,
}; };
/* /*
......
...@@ -705,6 +705,7 @@ static struct rpc_procinfo nfs4_cb_procedures[] = { ...@@ -705,6 +705,7 @@ static struct rpc_procinfo nfs4_cb_procedures[] = {
PROC(CB_NOTIFY_LOCK, COMPOUND, cb_notify_lock, cb_notify_lock), PROC(CB_NOTIFY_LOCK, COMPOUND, cb_notify_lock, cb_notify_lock),
}; };
static unsigned int nfs4_cb_counts[ARRAY_SIZE(nfs4_cb_procedures)];
static struct rpc_version nfs_cb_version4 = { static struct rpc_version nfs_cb_version4 = {
/* /*
* Note on the callback rpc program version number: despite language in rfc * Note on the callback rpc program version number: despite language in rfc
...@@ -715,7 +716,8 @@ static struct rpc_version nfs_cb_version4 = { ...@@ -715,7 +716,8 @@ static struct rpc_version nfs_cb_version4 = {
*/ */
.number = 1, .number = 1,
.nrprocs = ARRAY_SIZE(nfs4_cb_procedures), .nrprocs = ARRAY_SIZE(nfs4_cb_procedures),
.procs = nfs4_cb_procedures .procs = nfs4_cb_procedures,
.counts = nfs4_cb_counts,
}; };
static const struct rpc_version *nfs_cb_version[] = { static const struct rpc_version *nfs_cb_version[] = {
......
...@@ -88,6 +88,7 @@ struct rpc_version { ...@@ -88,6 +88,7 @@ struct rpc_version {
u32 number; /* version number */ u32 number; /* version number */
unsigned int nrprocs; /* number of procs */ unsigned int nrprocs; /* number of procs */
struct rpc_procinfo * procs; /* procedure array */ struct rpc_procinfo * procs; /* procedure array */
unsigned int *counts; /* call counts */
}; };
/* /*
...@@ -99,7 +100,6 @@ struct rpc_procinfo { ...@@ -99,7 +100,6 @@ struct rpc_procinfo {
kxdrdproc_t p_decode; /* XDR decode function */ kxdrdproc_t p_decode; /* XDR decode function */
unsigned int p_arglen; /* argument hdr length (u32) */ unsigned int p_arglen; /* argument hdr length (u32) */
unsigned int p_replen; /* reply hdr length (u32) */ unsigned int p_replen; /* reply hdr length (u32) */
unsigned int p_count; /* call count */
unsigned int p_timer; /* Which RTT timer to use */ unsigned int p_timer; /* Which RTT timer to use */
u32 p_statidx; /* Which procedure to account */ u32 p_statidx; /* Which procedure to account */
const char * p_name; /* name of procedure */ const char * p_name; /* name of procedure */
......
...@@ -364,11 +364,12 @@ void gssp_free_upcall_data(struct gssp_upcall_data *data) ...@@ -364,11 +364,12 @@ void gssp_free_upcall_data(struct gssp_upcall_data *data)
/* /*
* Initialization stuff * Initialization stuff
*/ */
static unsigned int gssp_version1_counts[ARRAY_SIZE(gssp_procedures)];
static const struct rpc_version gssp_version1 = { static const struct rpc_version gssp_version1 = {
.number = GSSPROXY_VERS_1, .number = GSSPROXY_VERS_1,
.nrprocs = ARRAY_SIZE(gssp_procedures), .nrprocs = ARRAY_SIZE(gssp_procedures),
.procs = gssp_procedures, .procs = gssp_procedures,
.counts = gssp_version1_counts,
}; };
static const struct rpc_version *gssp_version[] = { static const struct rpc_version *gssp_version[] = {
......
...@@ -1517,14 +1517,16 @@ static void ...@@ -1517,14 +1517,16 @@ static void
call_start(struct rpc_task *task) call_start(struct rpc_task *task)
{ {
struct rpc_clnt *clnt = task->tk_client; struct rpc_clnt *clnt = task->tk_client;
int idx = task->tk_msg.rpc_proc->p_statidx;
dprintk("RPC: %5u call_start %s%d proc %s (%s)\n", task->tk_pid, dprintk("RPC: %5u call_start %s%d proc %s (%s)\n", task->tk_pid,
clnt->cl_program->name, clnt->cl_vers, clnt->cl_program->name, clnt->cl_vers,
rpc_proc_name(task), rpc_proc_name(task),
(RPC_IS_ASYNC(task) ? "async" : "sync")); (RPC_IS_ASYNC(task) ? "async" : "sync"));
/* Increment call count */ /* Increment call count (version might not be valid for ping) */
task->tk_msg.rpc_proc->p_count++; if (clnt->cl_program->version[clnt->cl_vers])
clnt->cl_program->version[clnt->cl_vers]->counts[idx]++;
clnt->cl_stats->rpccnt++; clnt->cl_stats->rpccnt++;
task->tk_action = call_reserve; task->tk_action = call_reserve;
} }
......
...@@ -1117,22 +1117,28 @@ static const struct rpcb_info rpcb_next_version6[] = { ...@@ -1117,22 +1117,28 @@ static const struct rpcb_info rpcb_next_version6[] = {
}, },
}; };
static unsigned int rpcb_version2_counts[ARRAY_SIZE(rpcb_procedures2)];
static const struct rpc_version rpcb_version2 = { static const struct rpc_version rpcb_version2 = {
.number = RPCBVERS_2, .number = RPCBVERS_2,
.nrprocs = ARRAY_SIZE(rpcb_procedures2), .nrprocs = ARRAY_SIZE(rpcb_procedures2),
.procs = rpcb_procedures2 .procs = rpcb_procedures2,
.counts = rpcb_version2_counts,
}; };
static unsigned int rpcb_version3_counts[ARRAY_SIZE(rpcb_procedures3)];
static const struct rpc_version rpcb_version3 = { static const struct rpc_version rpcb_version3 = {
.number = RPCBVERS_3, .number = RPCBVERS_3,
.nrprocs = ARRAY_SIZE(rpcb_procedures3), .nrprocs = ARRAY_SIZE(rpcb_procedures3),
.procs = rpcb_procedures3 .procs = rpcb_procedures3,
.counts = rpcb_version3_counts,
}; };
static unsigned int rpcb_version4_counts[ARRAY_SIZE(rpcb_procedures4)];
static const struct rpc_version rpcb_version4 = { static const struct rpc_version rpcb_version4 = {
.number = RPCBVERS_4, .number = RPCBVERS_4,
.nrprocs = ARRAY_SIZE(rpcb_procedures4), .nrprocs = ARRAY_SIZE(rpcb_procedures4),
.procs = rpcb_procedures4 .procs = rpcb_procedures4,
.counts = rpcb_version4_counts,
}; };
static const struct rpc_version *rpcb_version[] = { static const struct rpc_version *rpcb_version[] = {
......
...@@ -55,8 +55,7 @@ static int rpc_proc_show(struct seq_file *seq, void *v) { ...@@ -55,8 +55,7 @@ static int rpc_proc_show(struct seq_file *seq, void *v) {
seq_printf(seq, "proc%u %u", seq_printf(seq, "proc%u %u",
vers->number, vers->nrprocs); vers->number, vers->nrprocs);
for (j = 0; j < vers->nrprocs; j++) for (j = 0; j < vers->nrprocs; j++)
seq_printf(seq, " %u", seq_printf(seq, " %u", vers->counts[j]);
vers->procs[j].p_count);
seq_putc(seq, '\n'); seq_putc(seq, '\n');
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment