Commit c59f02f8 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski

net: use WARN_ON_ONCE() in sk_stream_kill_queues()

sk_stream_kill_queues() has three checks which have been
useful to detect kernel bugs in the past.

However they are potentially a problem because they
could flood the syslog.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3e7f2b8d
...@@ -196,13 +196,13 @@ void sk_stream_kill_queues(struct sock *sk) ...@@ -196,13 +196,13 @@ void sk_stream_kill_queues(struct sock *sk)
__skb_queue_purge(&sk->sk_receive_queue); __skb_queue_purge(&sk->sk_receive_queue);
/* Next, the write queue. */ /* Next, the write queue. */
WARN_ON(!skb_queue_empty(&sk->sk_write_queue)); WARN_ON_ONCE(!skb_queue_empty(&sk->sk_write_queue));
/* Account for returned memory. */ /* Account for returned memory. */
sk_mem_reclaim_final(sk); sk_mem_reclaim_final(sk);
WARN_ON(sk->sk_wmem_queued); WARN_ON_ONCE(sk->sk_wmem_queued);
WARN_ON(sk->sk_forward_alloc); WARN_ON_ONCE(sk->sk_forward_alloc);
/* It is _impossible_ for the backlog to contain anything /* It is _impossible_ for the backlog to contain anything
* when we get here. All user references to this socket * when we get here. All user references to this socket
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment