Commit c5ed1fe0 authored by Yang Yingliang's avatar Yang Yingliang Committed by Thomas Bogendoerfer

MIPS: vpe-cmp: fix possible memory leak while module exiting

dev_set_name() allocates memory for name, it need be freed
when module exiting, call put_device() to give up reference,
so that it can be freed in kobject_cleanup() when the refcount
hit to 0. The vpe_device is static, so remove kfree() from
vpe_device_release().

Fixes: 17a1d523 ("MIPS: APRP: Add VPE loader support for CMP platforms.")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 5822e8cc
...@@ -75,7 +75,6 @@ ATTRIBUTE_GROUPS(vpe); ...@@ -75,7 +75,6 @@ ATTRIBUTE_GROUPS(vpe);
static void vpe_device_release(struct device *cd) static void vpe_device_release(struct device *cd)
{ {
kfree(cd);
} }
static struct class vpe_class = { static struct class vpe_class = {
...@@ -157,6 +156,7 @@ int __init vpe_module_init(void) ...@@ -157,6 +156,7 @@ int __init vpe_module_init(void)
device_del(&vpe_device); device_del(&vpe_device);
out_class: out_class:
put_device(&vpe_device);
class_unregister(&vpe_class); class_unregister(&vpe_class);
out_chrdev: out_chrdev:
...@@ -169,7 +169,7 @@ void __exit vpe_module_exit(void) ...@@ -169,7 +169,7 @@ void __exit vpe_module_exit(void)
{ {
struct vpe *v, *n; struct vpe *v, *n;
device_del(&vpe_device); device_unregister(&vpe_device);
class_unregister(&vpe_class); class_unregister(&vpe_class);
unregister_chrdev(major, VPE_MODULE_NAME); unregister_chrdev(major, VPE_MODULE_NAME);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment