Commit c7e261d8 authored by Ahmed S. Darwish's avatar Ahmed S. Darwish Committed by David S. Miller

net: mdiobus: Disable preemption upon u64_stats update

The u64_stats mechanism uses sequence counters to protect against 64-bit
values tearing on 32-bit architectures. Updating u64_stats is thus a
sequence counter write side critical section where preemption must be
disabled.

For mdiobus_stats_acct(), disable preemption upon the u64_stats update.
It is called from process context through mdiobus_read() and
mdiobus_write().
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarAhmed S. Darwish <a.darwish@linutronix.de>
Reviewed-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6501bf87
...@@ -764,6 +764,7 @@ EXPORT_SYMBOL(mdiobus_scan); ...@@ -764,6 +764,7 @@ EXPORT_SYMBOL(mdiobus_scan);
static void mdiobus_stats_acct(struct mdio_bus_stats *stats, bool op, int ret) static void mdiobus_stats_acct(struct mdio_bus_stats *stats, bool op, int ret)
{ {
preempt_disable();
u64_stats_update_begin(&stats->syncp); u64_stats_update_begin(&stats->syncp);
u64_stats_inc(&stats->transfers); u64_stats_inc(&stats->transfers);
...@@ -778,6 +779,7 @@ static void mdiobus_stats_acct(struct mdio_bus_stats *stats, bool op, int ret) ...@@ -778,6 +779,7 @@ static void mdiobus_stats_acct(struct mdio_bus_stats *stats, bool op, int ret)
u64_stats_inc(&stats->writes); u64_stats_inc(&stats->writes);
out: out:
u64_stats_update_end(&stats->syncp); u64_stats_update_end(&stats->syncp);
preempt_enable();
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment