Commit c7f268df authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Greg Kroah-Hartman

staging: line6: do not return 0 from probe if no initialization done

There is a strange "return 0" in line6_probe() before any initialization of
the module is done. It can lead to NULL pointer dereference in other functions.
The patch proposes to return -ENODEV in this case.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 07467e50
...@@ -663,7 +663,7 @@ static int line6_probe(struct usb_interface *interface, ...@@ -663,7 +663,7 @@ static int line6_probe(struct usb_interface *interface,
case LINE6_DEVID_POCKETPOD: case LINE6_DEVID_POCKETPOD:
switch (interface_number) { switch (interface_number) {
case 0: case 0:
return 0; /* this interface has no endpoints */ return -ENODEV; /* this interface has no endpoints */
case 1: case 1:
alternate = 0; alternate = 0;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment