Commit c87a405e authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu

crypto: ahash - remove useless setting of cra_type

Some ahash algorithms set .cra_type = &crypto_ahash_type.  But this is
redundant with the C structure type ('struct ahash_alg'), and
crypto_register_ahash() already sets the .cra_type automatically.
Apparently the useless assignment has just been copy+pasted around.

So, remove the useless assignment from all the ahash algorithms.

This patch shouldn't change any actual behavior.
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 6a38f622
...@@ -310,7 +310,6 @@ static struct ahash_alg ghash_async_alg = { ...@@ -310,7 +310,6 @@ static struct ahash_alg ghash_async_alg = {
.cra_priority = 300, .cra_priority = 300,
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = GHASH_BLOCK_SIZE, .cra_blocksize = GHASH_BLOCK_SIZE,
.cra_type = &crypto_ahash_type,
.cra_ctxsize = sizeof(struct ghash_async_ctx), .cra_ctxsize = sizeof(struct ghash_async_ctx),
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_init = ghash_async_init_tfm, .cra_init = ghash_async_init_tfm,
......
...@@ -316,7 +316,6 @@ static struct ahash_alg ghash_async_alg = { ...@@ -316,7 +316,6 @@ static struct ahash_alg ghash_async_alg = {
.cra_ctxsize = sizeof(struct ghash_async_ctx), .cra_ctxsize = sizeof(struct ghash_async_ctx),
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = GHASH_BLOCK_SIZE, .cra_blocksize = GHASH_BLOCK_SIZE,
.cra_type = &crypto_ahash_type,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_init = ghash_async_init_tfm, .cra_init = ghash_async_init_tfm,
.cra_exit = ghash_async_exit_tfm, .cra_exit = ghash_async_exit_tfm,
......
...@@ -880,7 +880,6 @@ static struct ahash_alg sha1_mb_async_alg = { ...@@ -880,7 +880,6 @@ static struct ahash_alg sha1_mb_async_alg = {
.cra_priority = 50, .cra_priority = 50,
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = SHA1_BLOCK_SIZE, .cra_blocksize = SHA1_BLOCK_SIZE,
.cra_type = &crypto_ahash_type,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_list = LIST_HEAD_INIT(sha1_mb_async_alg.halg.base.cra_list), .cra_list = LIST_HEAD_INIT(sha1_mb_async_alg.halg.base.cra_list),
.cra_init = sha1_mb_async_init_tfm, .cra_init = sha1_mb_async_init_tfm,
......
...@@ -879,7 +879,6 @@ static struct ahash_alg sha256_mb_async_alg = { ...@@ -879,7 +879,6 @@ static struct ahash_alg sha256_mb_async_alg = {
.cra_priority = 50, .cra_priority = 50,
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = SHA256_BLOCK_SIZE, .cra_blocksize = SHA256_BLOCK_SIZE,
.cra_type = &crypto_ahash_type,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_list = LIST_HEAD_INIT .cra_list = LIST_HEAD_INIT
(sha256_mb_async_alg.halg.base.cra_list), (sha256_mb_async_alg.halg.base.cra_list),
......
...@@ -913,7 +913,6 @@ static struct ahash_alg sha512_mb_async_alg = { ...@@ -913,7 +913,6 @@ static struct ahash_alg sha512_mb_async_alg = {
.cra_priority = 50, .cra_priority = 50,
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = SHA512_BLOCK_SIZE, .cra_blocksize = SHA512_BLOCK_SIZE,
.cra_type = &crypto_ahash_type,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_list = LIST_HEAD_INIT .cra_list = LIST_HEAD_INIT
(sha512_mb_async_alg.halg.base.cra_list), (sha512_mb_async_alg.halg.base.cra_list),
......
...@@ -4648,7 +4648,6 @@ static int spu_register_ahash(struct iproc_alg_s *driver_alg) ...@@ -4648,7 +4648,6 @@ static int spu_register_ahash(struct iproc_alg_s *driver_alg)
hash->halg.base.cra_ctxsize = sizeof(struct iproc_ctx_s); hash->halg.base.cra_ctxsize = sizeof(struct iproc_ctx_s);
hash->halg.base.cra_init = ahash_cra_init; hash->halg.base.cra_init = ahash_cra_init;
hash->halg.base.cra_exit = generic_cra_exit; hash->halg.base.cra_exit = generic_cra_exit;
hash->halg.base.cra_type = &crypto_ahash_type;
hash->halg.base.cra_flags = CRYPTO_ALG_ASYNC; hash->halg.base.cra_flags = CRYPTO_ALG_ASYNC;
hash->halg.statesize = sizeof(struct spu_hash_export_s); hash->halg.statesize = sizeof(struct spu_hash_export_s);
......
...@@ -1847,7 +1847,6 @@ caam_hash_alloc(struct caam_hash_template *template, ...@@ -1847,7 +1847,6 @@ caam_hash_alloc(struct caam_hash_template *template,
alg->cra_blocksize = template->blocksize; alg->cra_blocksize = template->blocksize;
alg->cra_alignmask = 0; alg->cra_alignmask = 0;
alg->cra_flags = CRYPTO_ALG_ASYNC; alg->cra_flags = CRYPTO_ALG_ASYNC;
alg->cra_type = &crypto_ahash_type;
t_alg->alg_type = template->alg_type; t_alg->alg_type = template->alg_type;
......
...@@ -405,7 +405,6 @@ int ccp_register_aes_cmac_algs(struct list_head *head) ...@@ -405,7 +405,6 @@ int ccp_register_aes_cmac_algs(struct list_head *head)
base->cra_blocksize = AES_BLOCK_SIZE; base->cra_blocksize = AES_BLOCK_SIZE;
base->cra_ctxsize = sizeof(struct ccp_ctx); base->cra_ctxsize = sizeof(struct ccp_ctx);
base->cra_priority = CCP_CRA_PRIORITY; base->cra_priority = CCP_CRA_PRIORITY;
base->cra_type = &crypto_ahash_type;
base->cra_init = ccp_aes_cmac_cra_init; base->cra_init = ccp_aes_cmac_cra_init;
base->cra_exit = ccp_aes_cmac_cra_exit; base->cra_exit = ccp_aes_cmac_cra_exit;
base->cra_module = THIS_MODULE; base->cra_module = THIS_MODULE;
......
...@@ -503,7 +503,6 @@ static int ccp_register_sha_alg(struct list_head *head, ...@@ -503,7 +503,6 @@ static int ccp_register_sha_alg(struct list_head *head,
base->cra_blocksize = def->block_size; base->cra_blocksize = def->block_size;
base->cra_ctxsize = sizeof(struct ccp_ctx); base->cra_ctxsize = sizeof(struct ccp_ctx);
base->cra_priority = CCP_CRA_PRIORITY; base->cra_priority = CCP_CRA_PRIORITY;
base->cra_type = &crypto_ahash_type;
base->cra_init = ccp_sha_cra_init; base->cra_init = ccp_sha_cra_init;
base->cra_exit = ccp_sha_cra_exit; base->cra_exit = ccp_sha_cra_exit;
base->cra_module = THIS_MODULE; base->cra_module = THIS_MODULE;
......
...@@ -1814,7 +1814,6 @@ static struct cc_hash_alg *cc_alloc_hash_alg(struct cc_hash_template *template, ...@@ -1814,7 +1814,6 @@ static struct cc_hash_alg *cc_alloc_hash_alg(struct cc_hash_template *template,
alg->cra_init = cc_cra_init; alg->cra_init = cc_cra_init;
alg->cra_flags = CRYPTO_ALG_ASYNC | CRYPTO_ALG_KERN_DRIVER_ONLY; alg->cra_flags = CRYPTO_ALG_ASYNC | CRYPTO_ALG_KERN_DRIVER_ONLY;
alg->cra_type = &crypto_ahash_type;
t_crypto_alg->hash_mode = template->hash_mode; t_crypto_alg->hash_mode = template->hash_mode;
t_crypto_alg->hw_mode = template->hw_mode; t_crypto_alg->hw_mode = template->hw_mode;
......
...@@ -4260,7 +4260,6 @@ static int chcr_register_alg(void) ...@@ -4260,7 +4260,6 @@ static int chcr_register_alg(void)
a_hash->halg.base.cra_flags = CRYPTO_ALG_ASYNC; a_hash->halg.base.cra_flags = CRYPTO_ALG_ASYNC;
a_hash->halg.base.cra_alignmask = 0; a_hash->halg.base.cra_alignmask = 0;
a_hash->halg.base.cra_exit = NULL; a_hash->halg.base.cra_exit = NULL;
a_hash->halg.base.cra_type = &crypto_ahash_type;
if (driver_algs[i].type == CRYPTO_ALG_TYPE_HMAC) { if (driver_algs[i].type == CRYPTO_ALG_TYPE_HMAC) {
a_hash->halg.base.cra_init = chcr_hmac_cra_init; a_hash->halg.base.cra_init = chcr_hmac_cra_init;
......
...@@ -48,7 +48,6 @@ static struct sun4i_ss_alg_template ss_algs[] = { ...@@ -48,7 +48,6 @@ static struct sun4i_ss_alg_template ss_algs[] = {
.cra_blocksize = MD5_HMAC_BLOCK_SIZE, .cra_blocksize = MD5_HMAC_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct sun4i_req_ctx), .cra_ctxsize = sizeof(struct sun4i_req_ctx),
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_type = &crypto_ahash_type,
.cra_init = sun4i_hash_crainit .cra_init = sun4i_hash_crainit
} }
} }
...@@ -75,7 +74,6 @@ static struct sun4i_ss_alg_template ss_algs[] = { ...@@ -75,7 +74,6 @@ static struct sun4i_ss_alg_template ss_algs[] = {
.cra_blocksize = SHA1_BLOCK_SIZE, .cra_blocksize = SHA1_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct sun4i_req_ctx), .cra_ctxsize = sizeof(struct sun4i_req_ctx),
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
.cra_type = &crypto_ahash_type,
.cra_init = sun4i_hash_crainit .cra_init = sun4i_hash_crainit
} }
} }
......
...@@ -3174,7 +3174,6 @@ static struct talitos_crypto_alg *talitos_alg_alloc(struct device *dev, ...@@ -3174,7 +3174,6 @@ static struct talitos_crypto_alg *talitos_alg_alloc(struct device *dev,
alg = &t_alg->algt.alg.hash.halg.base; alg = &t_alg->algt.alg.hash.halg.base;
alg->cra_init = talitos_cra_init_ahash; alg->cra_init = talitos_cra_init_ahash;
alg->cra_exit = talitos_cra_exit; alg->cra_exit = talitos_cra_exit;
alg->cra_type = &crypto_ahash_type;
t_alg->algt.alg.hash.init = ahash_init; t_alg->algt.alg.hash.init = ahash_init;
t_alg->algt.alg.hash.update = ahash_update; t_alg->algt.alg.hash.update = ahash_update;
t_alg->algt.alg.hash.final = ahash_final; t_alg->algt.alg.hash.final = ahash_final;
......
...@@ -1550,7 +1550,6 @@ static struct hash_algo_template hash_algs[] = { ...@@ -1550,7 +1550,6 @@ static struct hash_algo_template hash_algs[] = {
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = SHA256_BLOCK_SIZE, .cra_blocksize = SHA256_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct hash_ctx), .cra_ctxsize = sizeof(struct hash_ctx),
.cra_type = &crypto_ahash_type,
.cra_init = hash_cra_init, .cra_init = hash_cra_init,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
} }
...@@ -1575,7 +1574,6 @@ static struct hash_algo_template hash_algs[] = { ...@@ -1575,7 +1574,6 @@ static struct hash_algo_template hash_algs[] = {
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = SHA1_BLOCK_SIZE, .cra_blocksize = SHA1_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct hash_ctx), .cra_ctxsize = sizeof(struct hash_ctx),
.cra_type = &crypto_ahash_type,
.cra_init = hash_cra_init, .cra_init = hash_cra_init,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
} }
...@@ -1600,7 +1598,6 @@ static struct hash_algo_template hash_algs[] = { ...@@ -1600,7 +1598,6 @@ static struct hash_algo_template hash_algs[] = {
.cra_flags = CRYPTO_ALG_ASYNC, .cra_flags = CRYPTO_ALG_ASYNC,
.cra_blocksize = SHA256_BLOCK_SIZE, .cra_blocksize = SHA256_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct hash_ctx), .cra_ctxsize = sizeof(struct hash_ctx),
.cra_type = &crypto_ahash_type,
.cra_init = hash_cra_init, .cra_init = hash_cra_init,
.cra_module = THIS_MODULE, .cra_module = THIS_MODULE,
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment