Commit ca5f13a2 authored by Thomas Zimmermann's avatar Thomas Zimmermann

fbdev: Fix order of arguments to aperture_remove_conflicting_devices()

Reverse the order of the final two arguments when calling
aperture_remove_conflicting_devices(). An error report is available
at [1].
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Fixes: 8d69d008 ("fbdev: Convert drivers to aperture helpers")
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com> # hypervfb
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-hyperv@vger.kernel.org
Link: https://lore.kernel.org/lkml/202207202040.jS1WcTzN-lkp@intel.com/ # 1
Link: https://patchwork.freedesktop.org/patch/msgid/20220721081655.16128-1-tzimmermann@suse.de
parent fc94224c
...@@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev *pdev) ...@@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev *pdev)
resource_size_t base = pci_resource_start(pdev, 0); resource_size_t base = pci_resource_start(pdev, 0);
resource_size_t size = pci_resource_len(pdev, 0); resource_size_t size = pci_resource_len(pdev, 0);
return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME, false); return aperture_remove_conflicting_devices(base, size, false, KBUILD_MODNAME);
} }
static int radeonfb_pci_register(struct pci_dev *pdev, static int radeonfb_pci_register(struct pci_dev *pdev,
......
...@@ -1077,7 +1077,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info) ...@@ -1077,7 +1077,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info)
getmem_done: getmem_done:
aperture_remove_conflicting_devices(info->apertures->ranges[0].base, aperture_remove_conflicting_devices(info->apertures->ranges[0].base,
info->apertures->ranges[0].size, info->apertures->ranges[0].size,
KBUILD_MODNAME, false); false, KBUILD_MODNAME);
if (gen2vm) { if (gen2vm) {
/* framebuffer is reallocated, clear screen_info to avoid misuse from kexec */ /* framebuffer is reallocated, clear screen_info to avoid misuse from kexec */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment