Commit ca9ba892 authored by Sasha Levin's avatar Sasha Levin Committed by Greg Kroah-Hartman

PCI: Prevent out of bounds access in numa_node override

commit 12669631 upstream.

63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that
the numa node provided by userspace is valid.  Passing a node number too
high would attempt to access invalid memory and trigger a kernel panic.

Fixes: 63692df1 ("PCI: Allow numa_node override via sysfs")
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 310b5f12
...@@ -216,7 +216,7 @@ static ssize_t numa_node_store(struct device *dev, ...@@ -216,7 +216,7 @@ static ssize_t numa_node_store(struct device *dev,
if (ret) if (ret)
return ret; return ret;
if (!node_online(node)) if (node >= MAX_NUMNODES || !node_online(node))
return -EINVAL; return -EINVAL;
add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK); add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment