Commit cb020bf5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman

usb: musb: omap2430: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230405141009.3400693-8-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e6547b5e
...@@ -471,14 +471,12 @@ static int omap2430_probe(struct platform_device *pdev) ...@@ -471,14 +471,12 @@ static int omap2430_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int omap2430_remove(struct platform_device *pdev) static void omap2430_remove(struct platform_device *pdev)
{ {
struct omap2430_glue *glue = platform_get_drvdata(pdev); struct omap2430_glue *glue = platform_get_drvdata(pdev);
platform_device_unregister(glue->musb); platform_device_unregister(glue->musb);
pm_runtime_disable(glue->dev); pm_runtime_disable(glue->dev);
return 0;
} }
#ifdef CONFIG_PM #ifdef CONFIG_PM
...@@ -610,7 +608,7 @@ MODULE_DEVICE_TABLE(of, omap2430_id_table); ...@@ -610,7 +608,7 @@ MODULE_DEVICE_TABLE(of, omap2430_id_table);
static struct platform_driver omap2430_driver = { static struct platform_driver omap2430_driver = {
.probe = omap2430_probe, .probe = omap2430_probe,
.remove = omap2430_remove, .remove_new = omap2430_remove,
.driver = { .driver = {
.name = "musb-omap2430", .name = "musb-omap2430",
.pm = DEV_PM_OPS, .pm = DEV_PM_OPS,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment