Commit cb2200f7 authored by Joel Pepper's avatar Joel Pepper Committed by Laurent Pinchart

usb: gadget: uvc: configfs: Prevent format changes after linking header

While checks are in place to avoid attributes and children of a format
being manipulated after the format is linked into the streaming header,
the linked flag was never actually set, invalidating the protections.
Update the flag as appropriate in the header link calls.
Signed-off-by: default avatarJoel Pepper <joel.pepper@rwth-aachen.de>
Reviewed-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent b206548b
...@@ -928,6 +928,7 @@ static int uvcg_streaming_header_allow_link(struct config_item *src, ...@@ -928,6 +928,7 @@ static int uvcg_streaming_header_allow_link(struct config_item *src,
format_ptr->fmt = target_fmt; format_ptr->fmt = target_fmt;
list_add_tail(&format_ptr->entry, &src_hdr->formats); list_add_tail(&format_ptr->entry, &src_hdr->formats);
++src_hdr->num_fmt; ++src_hdr->num_fmt;
++target_fmt->linked;
out: out:
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
...@@ -965,6 +966,8 @@ static void uvcg_streaming_header_drop_link(struct config_item *src, ...@@ -965,6 +966,8 @@ static void uvcg_streaming_header_drop_link(struct config_item *src,
break; break;
} }
--target_fmt->linked;
out: out:
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
mutex_unlock(su_mutex); mutex_unlock(su_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment