Commit cb85ca33 authored by Lukasz Majewski's avatar Lukasz Majewski Committed by Guenter Roeck

hwmon: (pwm-fan) Extract __set_pwm() function to only modify PWM duty cycle

It was necessary to decouple code handling writing to sysfs from the one
responsible for setting PWM of the fan.
Due to that, new __set_pwm() method was extracted, which is responsible for
only setting new PWM duty cycle.
Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 73ef85f4
...@@ -33,20 +33,14 @@ struct pwm_fan_ctx { ...@@ -33,20 +33,14 @@ struct pwm_fan_ctx {
unsigned char pwm_value; unsigned char pwm_value;
}; };
static ssize_t set_pwm(struct device *dev, struct device_attribute *attr, static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
const char *buf, size_t count)
{ {
struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); unsigned long duty;
unsigned long pwm, duty; int ret = 0;
ssize_t ret;
if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM)
return -EINVAL;
mutex_lock(&ctx->lock); mutex_lock(&ctx->lock);
if (ctx->pwm_value == pwm) if (ctx->pwm_value == pwm)
goto exit_set_pwm_no_change; goto exit_set_pwm_err;
if (pwm == 0) { if (pwm == 0) {
pwm_disable(ctx->pwm); pwm_disable(ctx->pwm);
...@@ -66,13 +60,28 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr, ...@@ -66,13 +60,28 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
exit_set_pwm: exit_set_pwm:
ctx->pwm_value = pwm; ctx->pwm_value = pwm;
exit_set_pwm_no_change:
ret = count;
exit_set_pwm_err: exit_set_pwm_err:
mutex_unlock(&ctx->lock); mutex_unlock(&ctx->lock);
return ret; return ret;
} }
static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
unsigned long pwm;
int ret;
if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM)
return -EINVAL;
ret = __set_pwm(ctx, pwm);
if (ret)
return ret;
return count;
}
static ssize_t show_pwm(struct device *dev, static ssize_t show_pwm(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment