Commit cba7dfe0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones

backlight: lm3533_bl: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-8-u.kleine-koenig@pengutronix.de
parent c4c4fa57
...@@ -337,7 +337,7 @@ static int lm3533_bl_probe(struct platform_device *pdev) ...@@ -337,7 +337,7 @@ static int lm3533_bl_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int lm3533_bl_remove(struct platform_device *pdev) static void lm3533_bl_remove(struct platform_device *pdev)
{ {
struct lm3533_bl *bl = platform_get_drvdata(pdev); struct lm3533_bl *bl = platform_get_drvdata(pdev);
struct backlight_device *bd = bl->bd; struct backlight_device *bd = bl->bd;
...@@ -349,8 +349,6 @@ static int lm3533_bl_remove(struct platform_device *pdev) ...@@ -349,8 +349,6 @@ static int lm3533_bl_remove(struct platform_device *pdev)
lm3533_ctrlbank_disable(&bl->cb); lm3533_ctrlbank_disable(&bl->cb);
sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group);
return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
...@@ -390,7 +388,7 @@ static struct platform_driver lm3533_bl_driver = { ...@@ -390,7 +388,7 @@ static struct platform_driver lm3533_bl_driver = {
.pm = &lm3533_bl_pm_ops, .pm = &lm3533_bl_pm_ops,
}, },
.probe = lm3533_bl_probe, .probe = lm3533_bl_probe,
.remove = lm3533_bl_remove, .remove_new = lm3533_bl_remove,
.shutdown = lm3533_bl_shutdown, .shutdown = lm3533_bl_shutdown,
}; };
module_platform_driver(lm3533_bl_driver); module_platform_driver(lm3533_bl_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment