Commit cbd5458e authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Boris Ostrovsky

xen: Fix implicit type conversion

The variable 'i' is defined as UINT. However, in the for_each_possible_cpu
its value is assigned to -1. That doesn't make sense and in the
cpumask_next() it is implicitly type converted to INT. It is universally
accepted that the implicit type conversion is terrible. Also, having the
good programming custom will set an example for others. Thus, it might be
better to change the definition of 'i' from UINT to INT.

[boris: fixed commit message formatting]

Fixes: 3fac1014 ("xen: Re-upload processor PM data to hypervisor after S3 resume (v2)")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cnReviewed-by: default avatarJuergen Gross <jgross@suse.com>
Reviewed-by: default avatarJiamei Xie <jiamei.xie@arm.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent 9e2b3e83
...@@ -450,7 +450,7 @@ static struct acpi_processor_performance __percpu *acpi_perf_data; ...@@ -450,7 +450,7 @@ static struct acpi_processor_performance __percpu *acpi_perf_data;
static void free_acpi_perf_data(void) static void free_acpi_perf_data(void)
{ {
unsigned int i; int i;
/* Freeing a NULL pointer is OK, and alloc_percpu zeroes. */ /* Freeing a NULL pointer is OK, and alloc_percpu zeroes. */
for_each_possible_cpu(i) for_each_possible_cpu(i)
...@@ -462,7 +462,7 @@ static void free_acpi_perf_data(void) ...@@ -462,7 +462,7 @@ static void free_acpi_perf_data(void)
static int xen_upload_processor_pm_data(void) static int xen_upload_processor_pm_data(void)
{ {
struct acpi_processor *pr_backup = NULL; struct acpi_processor *pr_backup = NULL;
unsigned int i; int i;
int rc = 0; int rc = 0;
pr_info("Uploading Xen processor PM info\n"); pr_info("Uploading Xen processor PM info\n");
...@@ -518,7 +518,7 @@ static struct syscore_ops xap_syscore_ops = { ...@@ -518,7 +518,7 @@ static struct syscore_ops xap_syscore_ops = {
static int __init xen_acpi_processor_init(void) static int __init xen_acpi_processor_init(void)
{ {
unsigned int i; int i;
int rc; int rc;
if (!xen_initial_domain()) if (!xen_initial_domain())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment