Commit cc1dd5c8 authored by David Howells's avatar David Howells

afs: Fix incorrect error handling in afs_xattr_get_acl()

Fix incorrect error handling in afs_xattr_get_acl() where there appears to
be a redundant assignment before return, but in fact the return should be a
goto to the error handling at the end of the function.

Fixes: 260f082b ("afs: Get an AFS3 ACL as an xattr")
Addresses-Coverity: ("Unused Value")
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: Joe Perches <joe@perches.com>
parent a1b879ee
...@@ -71,11 +71,10 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler, ...@@ -71,11 +71,10 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler,
if (ret == 0) { if (ret == 0) {
ret = acl->size; ret = acl->size;
if (size > 0) { if (size > 0) {
ret = -ERANGE; if (acl->size <= size)
if (acl->size > size) memcpy(buffer, acl->data, acl->size);
return -ERANGE; else
memcpy(buffer, acl->data, acl->size); ret = -ERANGE;
ret = acl->size;
} }
kfree(acl); kfree(acl);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment