Commit cc708d4e authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jakub Kicinski

net: stmmac: dwmac-sun8i: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Acked-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarMichal Kubiak <michal.kubiak@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fec3f552
...@@ -1294,7 +1294,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) ...@@ -1294,7 +1294,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int sun8i_dwmac_remove(struct platform_device *pdev) static void sun8i_dwmac_remove(struct platform_device *pdev)
{ {
struct net_device *ndev = platform_get_drvdata(pdev); struct net_device *ndev = platform_get_drvdata(pdev);
struct stmmac_priv *priv = netdev_priv(ndev); struct stmmac_priv *priv = netdev_priv(ndev);
...@@ -1309,8 +1309,6 @@ static int sun8i_dwmac_remove(struct platform_device *pdev) ...@@ -1309,8 +1309,6 @@ static int sun8i_dwmac_remove(struct platform_device *pdev)
stmmac_pltfr_remove(pdev); stmmac_pltfr_remove(pdev);
sun8i_dwmac_unset_syscon(gmac); sun8i_dwmac_unset_syscon(gmac);
return 0;
} }
static void sun8i_dwmac_shutdown(struct platform_device *pdev) static void sun8i_dwmac_shutdown(struct platform_device *pdev)
...@@ -1341,7 +1339,7 @@ MODULE_DEVICE_TABLE(of, sun8i_dwmac_match); ...@@ -1341,7 +1339,7 @@ MODULE_DEVICE_TABLE(of, sun8i_dwmac_match);
static struct platform_driver sun8i_dwmac_driver = { static struct platform_driver sun8i_dwmac_driver = {
.probe = sun8i_dwmac_probe, .probe = sun8i_dwmac_probe,
.remove = sun8i_dwmac_remove, .remove_new = sun8i_dwmac_remove,
.shutdown = sun8i_dwmac_shutdown, .shutdown = sun8i_dwmac_shutdown,
.driver = { .driver = {
.name = "dwmac-sun8i", .name = "dwmac-sun8i",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment