Commit cc967be5 authored by Julia Lawall's avatar Julia Lawall Committed by Al Viro

fs: Add missing mutex_unlock

Add a mutex_unlock missing on the error path.  At other exists from the
function that return an error flag, the mutex is unlocked, so do the same
here.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1;
@@

* mutex_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1,...);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ea635c64
...@@ -1169,14 +1169,18 @@ long pipe_fcntl(struct file *file, unsigned int cmd, unsigned long arg) ...@@ -1169,14 +1169,18 @@ long pipe_fcntl(struct file *file, unsigned int cmd, unsigned long arg)
switch (cmd) { switch (cmd) {
case F_SETPIPE_SZ: case F_SETPIPE_SZ:
if (!capable(CAP_SYS_ADMIN) && arg > pipe_max_pages) if (!capable(CAP_SYS_ADMIN) && arg > pipe_max_pages) {
return -EINVAL; ret = -EINVAL;
goto out;
}
/* /*
* The pipe needs to be at least 2 pages large to * The pipe needs to be at least 2 pages large to
* guarantee POSIX behaviour. * guarantee POSIX behaviour.
*/ */
if (arg < 2) if (arg < 2) {
return -EINVAL; ret = -EINVAL;
goto out;
}
ret = pipe_set_size(pipe, arg); ret = pipe_set_size(pipe, arg);
break; break;
case F_GETPIPE_SZ: case F_GETPIPE_SZ:
...@@ -1187,6 +1191,7 @@ long pipe_fcntl(struct file *file, unsigned int cmd, unsigned long arg) ...@@ -1187,6 +1191,7 @@ long pipe_fcntl(struct file *file, unsigned int cmd, unsigned long arg)
break; break;
} }
out:
mutex_unlock(&pipe->inode->i_mutex); mutex_unlock(&pipe->inode->i_mutex);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment