Commit ccf56e5f authored by Masahiro Yamada's avatar Masahiro Yamada

kconfig: qconf: remove wrong ConfigList::firstChild()

This function returns the first child object, but the returned pointer
is not compatible with (ConfigItem *).

Commit cc1c08ed ("kconfig: qconf: don't show goback button on
splitMode") uncovered this issue because using the pointer from this
function would make qconf crash. (https://lkml.org/lkml/2020/7/18/411)

This function does not work. Remove.
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 4b20e103
...@@ -434,7 +434,7 @@ void ConfigList::updateList(ConfigItem* item) ...@@ -434,7 +434,7 @@ void ConfigList::updateList(ConfigItem* item)
} }
if ((mode == singleMode || (mode == symbolMode && !(rootEntry->flags & MENU_ROOT))) && if ((mode == singleMode || (mode == symbolMode && !(rootEntry->flags & MENU_ROOT))) &&
rootEntry->sym && rootEntry->prompt) { rootEntry->sym && rootEntry->prompt) {
item = last ? last->nextSibling() : firstChild(); item = last ? last->nextSibling() : nullptr;
if (!item) if (!item)
item = new ConfigItem(this, last, rootEntry, true); item = new ConfigItem(this, last, rootEntry, true);
else else
......
...@@ -92,10 +92,6 @@ public slots: ...@@ -92,10 +92,6 @@ public slots:
{ {
return this; return this;
} }
ConfigItem* firstChild() const
{
return (ConfigItem *)children().first();
}
void addColumn(colIdx idx) void addColumn(colIdx idx)
{ {
showColumn(idx); showColumn(idx);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment