Commit cd246fa9 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki

thermal: core: Clean up thermal_list_lock locking

Once thermal_list_lock has been acquired in
__thermal_cooling_device_register(), it is not necessary to drop it
and take it again until all of the thermal zones have been updated,
so change the code accordingly.

No expected functional impact.
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 0c7d0692
...@@ -826,8 +826,6 @@ static void bind_cdev(struct thermal_cooling_device *cdev) ...@@ -826,8 +826,6 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
const struct thermal_zone_params *tzp; const struct thermal_zone_params *tzp;
struct thermal_zone_device *pos = NULL; struct thermal_zone_device *pos = NULL;
mutex_lock(&thermal_list_lock);
list_for_each_entry(pos, &thermal_tz_list, node) { list_for_each_entry(pos, &thermal_tz_list, node) {
if (!pos->tzp && !pos->ops->bind) if (!pos->tzp && !pos->ops->bind)
continue; continue;
...@@ -854,8 +852,6 @@ static void bind_cdev(struct thermal_cooling_device *cdev) ...@@ -854,8 +852,6 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
tzp->tbp[i].weight); tzp->tbp[i].weight);
} }
} }
mutex_unlock(&thermal_list_lock);
} }
/** /**
...@@ -933,17 +929,17 @@ __thermal_cooling_device_register(struct device_node *np, ...@@ -933,17 +929,17 @@ __thermal_cooling_device_register(struct device_node *np,
/* Add 'this' new cdev to the global cdev list */ /* Add 'this' new cdev to the global cdev list */
mutex_lock(&thermal_list_lock); mutex_lock(&thermal_list_lock);
list_add(&cdev->node, &thermal_cdev_list); list_add(&cdev->node, &thermal_cdev_list);
mutex_unlock(&thermal_list_lock);
/* Update binding information for 'this' new cdev */ /* Update binding information for 'this' new cdev */
bind_cdev(cdev); bind_cdev(cdev);
mutex_lock(&thermal_list_lock);
list_for_each_entry(pos, &thermal_tz_list, node) list_for_each_entry(pos, &thermal_tz_list, node)
if (atomic_cmpxchg(&pos->need_update, 1, 0)) if (atomic_cmpxchg(&pos->need_update, 1, 0))
thermal_zone_device_update(pos, thermal_zone_device_update(pos,
THERMAL_EVENT_UNSPECIFIED); THERMAL_EVENT_UNSPECIFIED);
mutex_unlock(&thermal_list_lock); mutex_unlock(&thermal_list_lock);
return cdev; return cdev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment