Commit cda8e220 authored by Johan Hovold's avatar Johan Hovold Committed by Ben Hutchings

isdn/gigaset: fix NULL-deref at probe

commit 68c32f9c upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Fixes: cf7776dc ("[PATCH] isdn4linux: Siemens Gigaset drivers -
direct USB connection")
Cc: Hansjoerg Lipp <hjlipp@web.de>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 73e78a1d
...@@ -2314,6 +2314,9 @@ static int gigaset_probe(struct usb_interface *interface, ...@@ -2314,6 +2314,9 @@ static int gigaset_probe(struct usb_interface *interface,
return -ENODEV; return -ENODEV;
} }
if (hostif->desc.bNumEndpoints < 1)
return -ENODEV;
dev_info(&udev->dev, dev_info(&udev->dev,
"%s: Device matched (Vendor: 0x%x, Product: 0x%x)\n", "%s: Device matched (Vendor: 0x%x, Product: 0x%x)\n",
__func__, le16_to_cpu(udev->descriptor.idVendor), __func__, le16_to_cpu(udev->descriptor.idVendor),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment