Commit cdd91b89 authored by Vasant Hegde's avatar Vasant Hegde Committed by Michael Ellerman

powerpc/powernv: Improve error messages in dump code

Presently we only support initiating Service Processor dump from host.
Hence update sysfs message. Also update couple of other error/info
messages.
Signed-off-by: default avatarVasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 2172d660
...@@ -112,7 +112,7 @@ static ssize_t init_dump_show(struct dump_obj *dump_obj, ...@@ -112,7 +112,7 @@ static ssize_t init_dump_show(struct dump_obj *dump_obj,
struct dump_attribute *attr, struct dump_attribute *attr,
char *buf) char *buf)
{ {
return sprintf(buf, "1 - initiate dump\n"); return sprintf(buf, "1 - initiate Service Processor(FSP) dump\n");
} }
static int64_t dump_fips_init(uint8_t type) static int64_t dump_fips_init(uint8_t type)
...@@ -121,7 +121,7 @@ static int64_t dump_fips_init(uint8_t type) ...@@ -121,7 +121,7 @@ static int64_t dump_fips_init(uint8_t type)
rc = opal_dump_init(type); rc = opal_dump_init(type);
if (rc) if (rc)
pr_warn("%s: Failed to initiate FipS dump (%d)\n", pr_warn("%s: Failed to initiate FSP dump (%d)\n",
__func__, rc); __func__, rc);
return rc; return rc;
} }
...@@ -131,8 +131,12 @@ static ssize_t init_dump_store(struct dump_obj *dump_obj, ...@@ -131,8 +131,12 @@ static ssize_t init_dump_store(struct dump_obj *dump_obj,
const char *buf, const char *buf,
size_t count) size_t count)
{ {
dump_fips_init(DUMP_TYPE_FSP); int rc;
pr_info("%s: Initiated FSP dump\n", __func__);
rc = dump_fips_init(DUMP_TYPE_FSP);
if (rc == OPAL_SUCCESS)
pr_info("%s: Initiated FSP dump\n", __func__);
return count; return count;
} }
...@@ -297,7 +301,7 @@ static ssize_t dump_attr_read(struct file *filep, struct kobject *kobj, ...@@ -297,7 +301,7 @@ static ssize_t dump_attr_read(struct file *filep, struct kobject *kobj,
* and rely on userspace to ask us to try * and rely on userspace to ask us to try
* again. * again.
*/ */
pr_info("%s: Platform dump partially read.ID = 0x%x\n", pr_info("%s: Platform dump partially read. ID = 0x%x\n",
__func__, dump->id); __func__, dump->id);
return -EIO; return -EIO;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment