Commit ce035409 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Felipe Balbi

usb: phy: tahvo: fix error handling in tahvo_usb_probe()

If devm_extcon_dev_allocate() fails, we should disable clk before return.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 860d2686 ("usb: phy: tahvo: Use devm_extcon_dev_[allocate|register]() and replace deprecated API")
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent fdb5e4fa
...@@ -368,7 +368,8 @@ static int tahvo_usb_probe(struct platform_device *pdev) ...@@ -368,7 +368,8 @@ static int tahvo_usb_probe(struct platform_device *pdev)
tu->extcon = devm_extcon_dev_allocate(&pdev->dev, tahvo_cable); tu->extcon = devm_extcon_dev_allocate(&pdev->dev, tahvo_cable);
if (IS_ERR(tu->extcon)) { if (IS_ERR(tu->extcon)) {
dev_err(&pdev->dev, "failed to allocate memory for extcon\n"); dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
return -ENOMEM; ret = PTR_ERR(tu->extcon);
goto err_disable_clk;
} }
ret = devm_extcon_dev_register(&pdev->dev, tu->extcon); ret = devm_extcon_dev_register(&pdev->dev, tu->extcon);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment