Commit ce300008 authored by Bjorn Helgaas's avatar Bjorn Helgaas

PCI: Remove unnecessary list_empty(&pci_pme_list) check

list_for_each_entry() handles empty lists just fine, so there's no need to
check whether the list is empty first.

No functional change.
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarRafael J. Wysocki <rjw@rjwysocki.net>
parent 38dbfb59
...@@ -1611,29 +1611,27 @@ static void pci_pme_list_scan(struct work_struct *work) ...@@ -1611,29 +1611,27 @@ static void pci_pme_list_scan(struct work_struct *work)
struct pci_pme_device *pme_dev, *n; struct pci_pme_device *pme_dev, *n;
mutex_lock(&pci_pme_list_mutex); mutex_lock(&pci_pme_list_mutex);
if (!list_empty(&pci_pme_list)) { list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) {
list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { if (pme_dev->dev->pme_poll) {
if (pme_dev->dev->pme_poll) { struct pci_dev *bridge;
struct pci_dev *bridge;
bridge = pme_dev->dev->bus->self;
bridge = pme_dev->dev->bus->self; /*
/* * If bridge is in low power state, the
* If bridge is in low power state, the * configuration space of subordinate devices
* configuration space of subordinate devices * may be not accessible
* may be not accessible */
*/ if (bridge && bridge->current_state != PCI_D0)
if (bridge && bridge->current_state != PCI_D0) continue;
continue; pci_pme_wakeup(pme_dev->dev, NULL);
pci_pme_wakeup(pme_dev->dev, NULL); } else {
} else { list_del(&pme_dev->list);
list_del(&pme_dev->list); kfree(pme_dev);
kfree(pme_dev);
}
} }
if (!list_empty(&pci_pme_list))
schedule_delayed_work(&pci_pme_work,
msecs_to_jiffies(PME_TIMEOUT));
} }
if (!list_empty(&pci_pme_list))
schedule_delayed_work(&pci_pme_work,
msecs_to_jiffies(PME_TIMEOUT));
mutex_unlock(&pci_pme_list_mutex); mutex_unlock(&pci_pme_list_mutex);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment