Commit ce61856b authored by Eric Paris's avatar Eric Paris

dnotify: do not bother to lock entry->lock when reading mask

entry->lock is needed to make sure entry->mask does not change while
manipulating it.  In dnotify_should_send_event() we don't care if we get an
old or a new mask value out of this entry so there is no point it taking
the lock.
Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent 5ac697b7
...@@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group, ...@@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group,
if (!entry) if (!entry)
return false; return false;
spin_lock(&entry->lock);
send = (mask & entry->mask); send = (mask & entry->mask);
spin_unlock(&entry->lock);
fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */ fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */
return send; return send;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment