Commit cf642fae authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Pavel Machek

leds: lm3692x: Return 0 from remove callback

The only difference between returning zero or a non-zero value is that
for the non-zero case the i2c will print a generic error message
("remove failed (-ESOMETHING), will be ignored").

In this case however the driver itself already emitted a more helpful
error message, so the additional error message isn't helpful at all.

The long-term goal is to make the i2c remove callback return void, making
all implementations return 0 is preparatory work for this change.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 77d62fcc
......@@ -494,11 +494,8 @@ static int lm3692x_probe(struct i2c_client *client,
static int lm3692x_remove(struct i2c_client *client)
{
struct lm3692x_led *led = i2c_get_clientdata(client);
int ret;
ret = lm3692x_leds_disable(led);
if (ret)
return ret;
lm3692x_leds_disable(led);
mutex_destroy(&led->lock);
return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment