Commit cfe122db authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini

KVM: selftests: Rename vm_create_without_vcpus() => vm_create()

Rename vm_create_without_vcpus() to vm_create() so that it's not
misconstrued as helper that creates a VM that can never have vCPUs, as
opposed to a helper that "just" creates a VM without vCPUs added at time
zero.
Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 95fb0460
...@@ -78,7 +78,7 @@ static struct kvm_vm *setup_vm(void *guest_code) ...@@ -78,7 +78,7 @@ static struct kvm_vm *setup_vm(void *guest_code)
struct kvm_vcpu_init init; struct kvm_vcpu_init init;
struct kvm_vm *vm; struct kvm_vm *vm;
vm = vm_create_without_vcpus(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES); vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES);
ucall_init(vm, NULL); ucall_init(vm, NULL);
vm_ioctl(vm, KVM_ARM_PREFERRED_TARGET, &init); vm_ioctl(vm, KVM_ARM_PREFERRED_TARGET, &init);
......
...@@ -674,7 +674,7 @@ static struct kvm_vm *create_vm(enum vm_guest_mode mode, uint32_t vcpuid, ...@@ -674,7 +674,7 @@ static struct kvm_vm *create_vm(enum vm_guest_mode mode, uint32_t vcpuid,
pr_info("Testing guest mode: %s\n", vm_guest_mode_string(mode)); pr_info("Testing guest mode: %s\n", vm_guest_mode_string(mode));
vm = vm_create_without_vcpus(mode, DEFAULT_GUEST_PHY_PAGES + extra_pg_pages); vm = vm_create(mode, DEFAULT_GUEST_PHY_PAGES + extra_pg_pages);
log_mode_create_vm_done(vm); log_mode_create_vm_done(vm);
vm_vcpu_add_default(vm, vcpuid, guest_code); vm_vcpu_add_default(vm, vcpuid, guest_code);
......
...@@ -104,7 +104,7 @@ static void run_test(uint32_t run) ...@@ -104,7 +104,7 @@ static void run_test(uint32_t run)
for (i = 0; i < VCPU_NUM; i++) for (i = 0; i < VCPU_NUM; i++)
CPU_SET(i, &cpu_set); CPU_SET(i, &cpu_set);
vm = vm_create_without_vcpus(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES); vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES);
pr_debug("%s: [%d] start vcpus\n", __func__, run); pr_debug("%s: [%d] start vcpus\n", __func__, run);
for (i = 0; i < VCPU_NUM; ++i) { for (i = 0; i < VCPU_NUM; ++i) {
......
...@@ -630,7 +630,7 @@ struct kvm_vm *vm_create_with_vcpus(enum vm_guest_mode mode, uint32_t nr_vcpus, ...@@ -630,7 +630,7 @@ struct kvm_vm *vm_create_with_vcpus(enum vm_guest_mode mode, uint32_t nr_vcpus,
uint32_t vcpuids[]); uint32_t vcpuids[]);
/* Create a default VM without any vcpus. */ /* Create a default VM without any vcpus. */
struct kvm_vm *vm_create_without_vcpus(enum vm_guest_mode mode, uint64_t pages); struct kvm_vm *vm_create(enum vm_guest_mode mode, uint64_t pages);
/* /*
* Create a VM with a single vCPU with reasonable defaults and @extra_mem_pages * Create a VM with a single vCPU with reasonable defaults and @extra_mem_pages
......
...@@ -258,7 +258,7 @@ struct kvm_vm *__vm_create(enum vm_guest_mode mode, uint64_t phy_pages) ...@@ -258,7 +258,7 @@ struct kvm_vm *__vm_create(enum vm_guest_mode mode, uint64_t phy_pages)
return vm; return vm;
} }
struct kvm_vm *vm_create_without_vcpus(enum vm_guest_mode mode, uint64_t pages) struct kvm_vm *vm_create(enum vm_guest_mode mode, uint64_t pages)
{ {
struct kvm_vm *vm; struct kvm_vm *vm;
...@@ -323,7 +323,7 @@ struct kvm_vm *vm_create_with_vcpus(enum vm_guest_mode mode, uint32_t nr_vcpus, ...@@ -323,7 +323,7 @@ struct kvm_vm *vm_create_with_vcpus(enum vm_guest_mode mode, uint32_t nr_vcpus,
"nr_vcpus = %d too large for host, max-vcpus = %d", "nr_vcpus = %d too large for host, max-vcpus = %d",
nr_vcpus, kvm_check_cap(KVM_CAP_MAX_VCPUS)); nr_vcpus, kvm_check_cap(KVM_CAP_MAX_VCPUS));
vm = vm_create_without_vcpus(mode, pages); vm = vm_create(mode, pages);
for (i = 0; i < nr_vcpus; ++i) { for (i = 0; i < nr_vcpus; ++i) {
uint32_t vcpuid = vcpuids ? vcpuids[i] : i; uint32_t vcpuid = vcpuids ? vcpuids[i] : i;
......
...@@ -365,7 +365,7 @@ static void test_pmu_config_disable(void (*guest_code)(void)) ...@@ -365,7 +365,7 @@ static void test_pmu_config_disable(void (*guest_code)(void))
if (!(r & KVM_PMU_CAP_DISABLE)) if (!(r & KVM_PMU_CAP_DISABLE))
return; return;
vm = vm_create_without_vcpus(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES); vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES);
vm_enable_cap(vm, KVM_CAP_PMU_CAPABILITY, KVM_PMU_CAP_DISABLE); vm_enable_cap(vm, KVM_CAP_PMU_CAPABILITY, KVM_PMU_CAP_DISABLE);
......
...@@ -86,7 +86,7 @@ static struct kvm_vm *create_vm(void) ...@@ -86,7 +86,7 @@ static struct kvm_vm *create_vm(void)
uint64_t extra_pg_pages = vcpu_pages / PTES_PER_MIN_PAGE * N_VCPU; uint64_t extra_pg_pages = vcpu_pages / PTES_PER_MIN_PAGE * N_VCPU;
uint64_t pages = DEFAULT_GUEST_PHY_PAGES + vcpu_pages + extra_pg_pages; uint64_t pages = DEFAULT_GUEST_PHY_PAGES + vcpu_pages + extra_pg_pages;
return vm_create_without_vcpus(VM_MODE_DEFAULT, pages); return vm_create(VM_MODE_DEFAULT, pages);
} }
static void add_x86_vcpu(struct kvm_vm *vm, uint32_t vcpuid, bool bsp_code) static void add_x86_vcpu(struct kvm_vm *vm, uint32_t vcpuid, bool bsp_code)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment