Commit d0820556 authored by Stefano Brivio's avatar Stefano Brivio Committed by Pablo Neira Ayuso

selftests: nft_concat_range: Move option for 'list ruleset' before command

Before nftables commit fb9cea50e8b3 ("main: enforce options before
commands"), 'nft list ruleset -a' happened to work, but it's wrong
and won't work anymore. Replace it by 'nft -a list ruleset'.
Reported-by: default avatarChen Yi <yiche@redhat.com>
Fixes: 611973c1 ("selftests: netfilter: Introduce tests for sets with range concatenation")
Signed-off-by: default avatarStefano Brivio <sbrivio@redhat.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 3614d05b
...@@ -1025,7 +1025,7 @@ format_noconcat() { ...@@ -1025,7 +1025,7 @@ format_noconcat() {
add() { add() {
if ! nft add element inet filter test "${1}"; then if ! nft add element inet filter test "${1}"; then
err "Failed to add ${1} given ruleset:" err "Failed to add ${1} given ruleset:"
err "$(nft list ruleset -a)" err "$(nft -a list ruleset)"
return 1 return 1
fi fi
} }
...@@ -1045,7 +1045,7 @@ add_perf() { ...@@ -1045,7 +1045,7 @@ add_perf() {
add_perf_norange() { add_perf_norange() {
if ! nft add element netdev perf norange "${1}"; then if ! nft add element netdev perf norange "${1}"; then
err "Failed to add ${1} given ruleset:" err "Failed to add ${1} given ruleset:"
err "$(nft list ruleset -a)" err "$(nft -a list ruleset)"
return 1 return 1
fi fi
} }
...@@ -1054,7 +1054,7 @@ add_perf_norange() { ...@@ -1054,7 +1054,7 @@ add_perf_norange() {
add_perf_noconcat() { add_perf_noconcat() {
if ! nft add element netdev perf noconcat "${1}"; then if ! nft add element netdev perf noconcat "${1}"; then
err "Failed to add ${1} given ruleset:" err "Failed to add ${1} given ruleset:"
err "$(nft list ruleset -a)" err "$(nft -a list ruleset)"
return 1 return 1
fi fi
} }
...@@ -1063,7 +1063,7 @@ add_perf_noconcat() { ...@@ -1063,7 +1063,7 @@ add_perf_noconcat() {
del() { del() {
if ! nft delete element inet filter test "${1}"; then if ! nft delete element inet filter test "${1}"; then
err "Failed to delete ${1} given ruleset:" err "Failed to delete ${1} given ruleset:"
err "$(nft list ruleset -a)" err "$(nft -a list ruleset)"
return 1 return 1
fi fi
} }
...@@ -1134,7 +1134,7 @@ send_match() { ...@@ -1134,7 +1134,7 @@ send_match() {
err " $(for f in ${src}; do err " $(for f in ${src}; do
eval format_\$f "${2}"; printf ' '; done)" eval format_\$f "${2}"; printf ' '; done)"
err "should have matched ruleset:" err "should have matched ruleset:"
err "$(nft list ruleset -a)" err "$(nft -a list ruleset)"
return 1 return 1
fi fi
nft reset counter inet filter test >/dev/null nft reset counter inet filter test >/dev/null
...@@ -1160,7 +1160,7 @@ send_nomatch() { ...@@ -1160,7 +1160,7 @@ send_nomatch() {
err " $(for f in ${src}; do err " $(for f in ${src}; do
eval format_\$f "${2}"; printf ' '; done)" eval format_\$f "${2}"; printf ' '; done)"
err "should not have matched ruleset:" err "should not have matched ruleset:"
err "$(nft list ruleset -a)" err "$(nft -a list ruleset)"
return 1 return 1
fi fi
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment