Commit d14eb80e authored by Daniel Mack's avatar Daniel Mack Committed by Daniel Vetter

drm/panel: ili9341: fix optional regulator handling

If the optional regulator lookup fails, reset the pointer to NULL.
Other functions such as mipi_dbi_poweron_reset_conditional() only do
a NULL pointer check and will otherwise dereference the error pointer.

Fixes: 5a042273 ("drm/panel: Add ilitek ili9341 panel driver")
Signed-off-by: default avatarDaniel Mack <daniel@zonque.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220317225537.826302-1-daniel@zonque.org
parent 3c338405
...@@ -612,8 +612,10 @@ static int ili9341_dbi_probe(struct spi_device *spi, struct gpio_desc *dc, ...@@ -612,8 +612,10 @@ static int ili9341_dbi_probe(struct spi_device *spi, struct gpio_desc *dc,
int ret; int ret;
vcc = devm_regulator_get_optional(dev, "vcc"); vcc = devm_regulator_get_optional(dev, "vcc");
if (IS_ERR(vcc)) if (IS_ERR(vcc)) {
dev_err(dev, "get optional vcc failed\n"); dev_err(dev, "get optional vcc failed\n");
vcc = NULL;
}
dbidev = devm_drm_dev_alloc(dev, &ili9341_dbi_driver, dbidev = devm_drm_dev_alloc(dev, &ili9341_dbi_driver,
struct mipi_dbi_dev, drm); struct mipi_dbi_dev, drm);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment