Commit d1e7f009 authored by Minghao Chi's avatar Minghao Chi Committed by Paolo Abeni

net: qede: Remove unnecessary synchronize_irq() before free_irq()

Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarMinghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220516082251.1651350-1-chi.minghao@zte.com.cnSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent bd81bfb5
...@@ -1916,7 +1916,6 @@ static void qede_sync_free_irqs(struct qede_dev *edev) ...@@ -1916,7 +1916,6 @@ static void qede_sync_free_irqs(struct qede_dev *edev)
for (i = 0; i < edev->int_info.used_cnt; i++) { for (i = 0; i < edev->int_info.used_cnt; i++) {
if (edev->int_info.msix_cnt) { if (edev->int_info.msix_cnt) {
synchronize_irq(edev->int_info.msix[i].vector);
free_irq(edev->int_info.msix[i].vector, free_irq(edev->int_info.msix[i].vector,
&edev->fp_array[i]); &edev->fp_array[i]);
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment