Commit d1ef006d authored by David Vrabel's avatar David Vrabel Committed by David S. Miller

xen-netback: fix guest Rx stall detection (after guest Rx refactor)

If a VIF has been ready for rx_stall_timeout (60s by default) and an
Rx ring is drained of all requests an Rx stall will be incorrectly
detected.  When this occurs and the guest Rx queue is empty, the Rx
ring's event index will not be set and the frontend will not raise an
event when new requests are placed on the ring, permanently stalling
the VIF.

This is a regression introduced by eb1723a2 (xen-netback:
refactor guest rx).

Fix this by reinstating the setting of queue->last_rx_time when
placing a packet onto the guest Rx ring.
Signed-off-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
Reviewed-by: default avatarPaul Durrant <paul.durrant@citrix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 02a9079c
...@@ -425,6 +425,8 @@ void xenvif_rx_skb(struct xenvif_queue *queue) ...@@ -425,6 +425,8 @@ void xenvif_rx_skb(struct xenvif_queue *queue)
xenvif_rx_next_skb(queue, &pkt); xenvif_rx_next_skb(queue, &pkt);
queue->last_rx_time = jiffies;
do { do {
struct xen_netif_rx_request *req; struct xen_netif_rx_request *req;
struct xen_netif_rx_response *rsp; struct xen_netif_rx_response *rsp;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment