Commit d1fd03a3 authored by Wei Yongjun's avatar Wei Yongjun Committed by Vinod Koul

dmaengine: ti: edma: Fix error return code in edma_probe()

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 2a03c131 ("dmaengine: ti: edma: add missed operations")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191212114622.127322-1-weiyongjun1@huawei.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent a5b982af
...@@ -2342,8 +2342,10 @@ static int edma_probe(struct platform_device *pdev) ...@@ -2342,8 +2342,10 @@ static int edma_probe(struct platform_device *pdev)
ecc->channels_mask = devm_kcalloc(dev, ecc->channels_mask = devm_kcalloc(dev,
BITS_TO_LONGS(ecc->num_channels), BITS_TO_LONGS(ecc->num_channels),
sizeof(unsigned long), GFP_KERNEL); sizeof(unsigned long), GFP_KERNEL);
if (!ecc->slave_chans || !ecc->slot_inuse || !ecc->channels_mask) if (!ecc->slave_chans || !ecc->slot_inuse || !ecc->channels_mask) {
ret = -ENOMEM;
goto err_disable_pm; goto err_disable_pm;
}
/* Mark all channels available initially */ /* Mark all channels available initially */
bitmap_fill(ecc->channels_mask, ecc->num_channels); bitmap_fill(ecc->channels_mask, ecc->num_channels);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment