Commit d2a0a616 authored by Frédéric Danis's avatar Frédéric Danis Committed by Richard Weinberger

um: Fix WRITE_ZEROES in the UBD Driver

Call to fallocate with FALLOC_FL_PUNCH_HOLE on a device backed by a sparse
file can end up by missing data, zeroes data range, if the underlying file
is used with a tool like bmaptool which will referenced only used spaces.
Signed-off-by: default avatarFrédéric Danis <frederic.danis@collabora.com>
Acked-by: default avatarAnton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent b35507a4
...@@ -1526,13 +1526,19 @@ static void do_io(struct io_thread_req *req, struct io_desc *desc) ...@@ -1526,13 +1526,19 @@ static void do_io(struct io_thread_req *req, struct io_desc *desc)
} }
break; break;
case REQ_OP_DISCARD: case REQ_OP_DISCARD:
case REQ_OP_WRITE_ZEROES:
n = os_falloc_punch(req->fds[bit], off, len); n = os_falloc_punch(req->fds[bit], off, len);
if (n) { if (n) {
req->error = map_error(-n); req->error = map_error(-n);
return; return;
} }
break; break;
case REQ_OP_WRITE_ZEROES:
n = os_falloc_zeroes(req->fds[bit], off, len);
if (n) {
req->error = map_error(-n);
return;
}
break;
default: default:
WARN_ON_ONCE(1); WARN_ON_ONCE(1);
req->error = BLK_STS_NOTSUPP; req->error = BLK_STS_NOTSUPP;
......
...@@ -168,6 +168,7 @@ extern unsigned os_major(unsigned long long dev); ...@@ -168,6 +168,7 @@ extern unsigned os_major(unsigned long long dev);
extern unsigned os_minor(unsigned long long dev); extern unsigned os_minor(unsigned long long dev);
extern unsigned long long os_makedev(unsigned major, unsigned minor); extern unsigned long long os_makedev(unsigned major, unsigned minor);
extern int os_falloc_punch(int fd, unsigned long long offset, int count); extern int os_falloc_punch(int fd, unsigned long long offset, int count);
extern int os_falloc_zeroes(int fd, unsigned long long offset, int count);
extern int os_eventfd(unsigned int initval, int flags); extern int os_eventfd(unsigned int initval, int flags);
extern int os_sendmsg_fds(int fd, const void *buf, unsigned int len, extern int os_sendmsg_fds(int fd, const void *buf, unsigned int len,
const int *fds, unsigned int fds_num); const int *fds, unsigned int fds_num);
......
...@@ -625,6 +625,15 @@ int os_falloc_punch(int fd, unsigned long long offset, int len) ...@@ -625,6 +625,15 @@ int os_falloc_punch(int fd, unsigned long long offset, int len)
return n; return n;
} }
int os_falloc_zeroes(int fd, unsigned long long offset, int len)
{
int n = fallocate(fd, FALLOC_FL_ZERO_RANGE|FALLOC_FL_KEEP_SIZE, offset, len);
if (n < 0)
return -errno;
return n;
}
int os_eventfd(unsigned int initval, int flags) int os_eventfd(unsigned int initval, int flags)
{ {
int fd = eventfd(initval, flags); int fd = eventfd(initval, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment