Commit d2cc2f0b authored by Laura Abbott's avatar Laura Abbott Committed by Mauro Carvalho Chehab

[media] si2157: return -EINVAL if firmware blob is too big

A previous patch added a check if the firmware is too big, but it didn't
set the return error code with the right value.

[mchehab@osg.samsung.com: I ended by applying a v1 of Laura's patch, without
 the proper return code. This patch contains the difference between v2 and v1 of
 the Laura's "si2157: Bounds check firmware" patch]
Cc: stable@kernel.org
Signed-off-by: default avatarLaura Abbott <labbott@fedoraproject.org>
Reviewed-by: default avatarOlli Salonen <olli.salonen@iki.fi>
Tested-by: default avatarOlli Salonen <olli.salonen@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 3bbc78ae
...@@ -168,6 +168,7 @@ static int si2157_init(struct dvb_frontend *fe) ...@@ -168,6 +168,7 @@ static int si2157_init(struct dvb_frontend *fe)
len = fw->data[fw->size - remaining]; len = fw->data[fw->size - remaining];
if (len > SI2157_ARGLEN) { if (len > SI2157_ARGLEN) {
dev_err(&client->dev, "Bad firmware length\n"); dev_err(&client->dev, "Bad firmware length\n");
ret = -EINVAL;
goto err_release_firmware; goto err_release_firmware;
} }
memcpy(cmd.args, &fw->data[(fw->size - remaining) + 1], len); memcpy(cmd.args, &fw->data[(fw->size - remaining) + 1], len);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment