Commit d4a76dc7 authored by Antoine Tenart's avatar Antoine Tenart Committed by David S. Miller

net: phy: mscc: remove useless page configuration in the config init

In the middle of vsc8584_config_init and vsc8514_config_init, the page
is set to 'standard'. This is the default value, and the page isn't set
to another value before. Those pages configuration can be safely
removed.
Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6119dda3
...@@ -1443,8 +1443,6 @@ static int vsc8584_config_init(struct phy_device *phydev) ...@@ -1443,8 +1443,6 @@ static int vsc8584_config_init(struct phy_device *phydev)
if (ret) if (ret)
return ret; return ret;
phy_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1); val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1);
val &= ~(MEDIA_OP_MODE_MASK | VSC8584_MAC_IF_SELECTION_MASK); val &= ~(MEDIA_OP_MODE_MASK | VSC8584_MAC_IF_SELECTION_MASK);
val |= (MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS) | val |= (MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS) |
...@@ -1892,11 +1890,6 @@ static int vsc8514_config_init(struct phy_device *phydev) ...@@ -1892,11 +1890,6 @@ static int vsc8514_config_init(struct phy_device *phydev)
phy_unlock_mdio_bus(phydev); phy_unlock_mdio_bus(phydev);
ret = phy_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
if (ret)
return ret;
ret = phy_modify(phydev, MSCC_PHY_EXT_PHY_CNTL_1, MEDIA_OP_MODE_MASK, ret = phy_modify(phydev, MSCC_PHY_EXT_PHY_CNTL_1, MEDIA_OP_MODE_MASK,
MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS); MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment