Commit d56b4779 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher

fm10k: reduce the scope of the local i variable

Reduce the scope of the local loop variable in the
fm10k_check_hang_subtask function.

This was detected by cppcheck and resolves the following warning
produced by that tool:

[driver/fm10k_pci.c:852]: (style) The scope of the variable 'i' can be
reduced.
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent b731d079
...@@ -698,8 +698,6 @@ static void fm10k_watchdog_subtask(struct fm10k_intfc *interface) ...@@ -698,8 +698,6 @@ static void fm10k_watchdog_subtask(struct fm10k_intfc *interface)
*/ */
static void fm10k_check_hang_subtask(struct fm10k_intfc *interface) static void fm10k_check_hang_subtask(struct fm10k_intfc *interface)
{ {
int i;
/* If we're down or resetting, just bail */ /* If we're down or resetting, just bail */
if (test_bit(__FM10K_DOWN, interface->state) || if (test_bit(__FM10K_DOWN, interface->state) ||
test_bit(__FM10K_RESETTING, interface->state)) test_bit(__FM10K_RESETTING, interface->state))
...@@ -711,6 +709,8 @@ static void fm10k_check_hang_subtask(struct fm10k_intfc *interface) ...@@ -711,6 +709,8 @@ static void fm10k_check_hang_subtask(struct fm10k_intfc *interface)
interface->next_tx_hang_check = jiffies + (2 * HZ); interface->next_tx_hang_check = jiffies + (2 * HZ);
if (netif_carrier_ok(interface->netdev)) { if (netif_carrier_ok(interface->netdev)) {
int i;
/* Force detection of hung controller */ /* Force detection of hung controller */
for (i = 0; i < interface->num_tx_queues; i++) for (i = 0; i < interface->num_tx_queues; i++)
set_check_for_tx_hang(interface->tx_ring[i]); set_check_for_tx_hang(interface->tx_ring[i]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment