Commit d5e0d0f6 authored by Mathias Krause's avatar Mathias Krause Committed by David S. Miller

VSOCK: Fix missing msg_namelen update in vsock_stream_recvmsg()

The code misses to update the msg_namelen member to 0 and therefore
makes net/socket.c leak the local, uninitialized sockaddr_storage
variable to userland -- 128 bytes of kernel stack memory.

Cc: Andy King <acking@vmware.com>
Cc: Dmitry Torokhov <dtor@vmware.com>
Cc: George Zhang <georgezhang@vmware.com>
Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 680d04e0
...@@ -1670,6 +1670,8 @@ vsock_stream_recvmsg(struct kiocb *kiocb, ...@@ -1670,6 +1670,8 @@ vsock_stream_recvmsg(struct kiocb *kiocb,
vsk = vsock_sk(sk); vsk = vsock_sk(sk);
err = 0; err = 0;
msg->msg_namelen = 0;
lock_sock(sk); lock_sock(sk);
if (sk->sk_state != SS_CONNECTED) { if (sk->sk_state != SS_CONNECTED) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment