Commit d643bdca authored by H. Peter Anvin's avatar H. Peter Anvin

asm-generic: Allow overriding clock_t and add attributes to siginfo_t

For the particular issue of x32, which shares code with i386 in the
handling of compat_siginfo_t, the use of a 64-bit clock_t bumps the
sigchld structure out of alignment, which triggers a messy cascade of
padding.

This was already handled on the kernel compat side, but it needs
handling on the user space side, which uses the generic header.  To
make that possible:

1. Allow __kernel_clock_t to be overridden in struct siginfo;
2. Allow there to be attributes added to struct siginfo.
Reported-by: default avatarH.J. Lu <hjl.rools@gmail.com>
Cc: Bruce J. Beare <bruce.j.beare@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Link: http://lkml.kernel.org/r/CAMe9rOqF6Kh6-NK7oP0Fpzkd4SBAWU%2BG53hwBbSD4iA2UzyxuA@mail.gmail.comSigned-off-by: default avatarH. Peter Anvin <hpa@linux.intel.com>
parent 98e5272f
...@@ -35,6 +35,14 @@ typedef union sigval { ...@@ -35,6 +35,14 @@ typedef union sigval {
#define __ARCH_SI_BAND_T long #define __ARCH_SI_BAND_T long
#endif #endif
#ifndef __ARCH_SI_CLOCK_T
#define __ARCH_SI_CLOCK_T __kernel_clock_t
#endif
#ifndef __ARCH_SI_ATTRIBUTES
#define __ARCH_SI_ATTRIBUTES
#endif
#ifndef HAVE_ARCH_SIGINFO_T #ifndef HAVE_ARCH_SIGINFO_T
typedef struct siginfo { typedef struct siginfo {
...@@ -72,8 +80,8 @@ typedef struct siginfo { ...@@ -72,8 +80,8 @@ typedef struct siginfo {
__kernel_pid_t _pid; /* which child */ __kernel_pid_t _pid; /* which child */
__ARCH_SI_UID_T _uid; /* sender's uid */ __ARCH_SI_UID_T _uid; /* sender's uid */
int _status; /* exit code */ int _status; /* exit code */
__kernel_clock_t _utime; __ARCH_SI_CLOCK_T _utime;
__kernel_clock_t _stime; __ARCH_SI_CLOCK_T _stime;
} _sigchld; } _sigchld;
/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ /* SIGILL, SIGFPE, SIGSEGV, SIGBUS */
...@@ -91,7 +99,7 @@ typedef struct siginfo { ...@@ -91,7 +99,7 @@ typedef struct siginfo {
int _fd; int _fd;
} _sigpoll; } _sigpoll;
} _sifields; } _sifields;
} siginfo_t; } __ARCH_SI_ATTRIBUTES siginfo_t;
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment