Commit d6b340d7 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: trident: Suppress gcc string warning

The meddlesome gcc warns about the possible shortname string in
trident driver code:
  sound/pci/trident/trident.c: In function ‘snd_trident_probe’:
  sound/pci/trident/trident.c:126:2: warning: ‘strcat’ accessing 17 or more bytes at offsets 36 and 20 may overlap 1 byte at offset 36 [-Wrestrict]
  strcat(card->shortname, card->driver);

It happens since gcc calculates the possible string size from
card->driver, but this can't be true since we did set the string just
before that, and they are much shorter.

For shutting it up, use the exactly same string set to card->driver
for strcat() to card->shortname, too.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 63623646
...@@ -123,7 +123,7 @@ static int snd_trident_probe(struct pci_dev *pci, ...@@ -123,7 +123,7 @@ static int snd_trident_probe(struct pci_dev *pci,
} else { } else {
strcpy(card->shortname, "Trident "); strcpy(card->shortname, "Trident ");
} }
strcat(card->shortname, card->driver); strcat(card->shortname, str);
sprintf(card->longname, "%s PCI Audio at 0x%lx, irq %d", sprintf(card->longname, "%s PCI Audio at 0x%lx, irq %d",
card->shortname, trident->port, trident->irq); card->shortname, trident->port, trident->irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment