Commit d6e34091 authored by Shravan Chippa's avatar Shravan Chippa Committed by Mauro Carvalho Chehab

media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range

For every mode we will get new set of values for hbalnk so use
__v4l2_ctrl_modify_range() to support multi modes for hblank.

The hblank value is readonly in the driver. because of this the function
returns error if we try to change. so added dumy return case in
imx334_set_ctrl function.
Reviewed-by: default avatarJacopo Mondi <jacopo.mondi@ideasonboard.com>
Suggested-by: default avatarJacopo Mondi <jacopo@jmondi.org>
Signed-off-by: default avatarShravan Chippa <shravan.chippa@microchip.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 7370f639
...@@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334, ...@@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334,
if (ret) if (ret)
return ret; return ret;
ret = __v4l2_ctrl_s_ctrl(imx334->hblank_ctrl, mode->hblank); ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode->hblank,
mode->hblank, 1, mode->hblank);
if (ret) if (ret)
return ret; return ret;
...@@ -480,6 +481,9 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl) ...@@ -480,6 +481,9 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
pm_runtime_put(imx334->dev); pm_runtime_put(imx334->dev);
break;
case V4L2_CID_HBLANK:
ret = 0;
break; break;
default: default:
dev_err(imx334->dev, "Invalid control %d", ctrl->id); dev_err(imx334->dev, "Invalid control %d", ctrl->id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment