Commit d72e04d9 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Alex Deucher

drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

clang warns:

drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:995:39: warning:
implicit conversion from enumeration type 'PPCLK_e' to different
enumeration type 'enum smu_clk_type' [-Wenum-conversion]
                ret = smu_get_current_clk_freq(smu, PPCLK_SOCCLK, &now);
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:1016:39: warning:
implicit conversion from enumeration type 'PPCLK_e' to different
enumeration type 'enum smu_clk_type' [-Wenum-conversion]
                ret = smu_get_current_clk_freq(smu, PPCLK_FCLK, &now);
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:1031:39: warning:
implicit conversion from enumeration type 'PPCLK_e' to different
enumeration type 'enum smu_clk_type' [-Wenum-conversion]
                ret = smu_get_current_clk_freq(smu, PPCLK_DCEFCLK, &now);
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~

The values are mapped one to one in vega20_get_smu_clk_index so just use
the proper enums here.

Fixes: 09676101 ("drm/amd/powerplay: support sysfs to get socclk, fclk, dcefclk")
Link: https://github.com/ClangBuiltLinux/linux/issues/587Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 08473888
...@@ -992,7 +992,7 @@ static int vega20_print_clk_levels(struct smu_context *smu, ...@@ -992,7 +992,7 @@ static int vega20_print_clk_levels(struct smu_context *smu,
break; break;
case SMU_SOCCLK: case SMU_SOCCLK:
ret = smu_get_current_clk_freq(smu, PPCLK_SOCCLK, &now); ret = smu_get_current_clk_freq(smu, SMU_SOCCLK, &now);
if (ret) { if (ret) {
pr_err("Attempt to get current socclk Failed!"); pr_err("Attempt to get current socclk Failed!");
return ret; return ret;
...@@ -1013,7 +1013,7 @@ static int vega20_print_clk_levels(struct smu_context *smu, ...@@ -1013,7 +1013,7 @@ static int vega20_print_clk_levels(struct smu_context *smu,
break; break;
case SMU_FCLK: case SMU_FCLK:
ret = smu_get_current_clk_freq(smu, PPCLK_FCLK, &now); ret = smu_get_current_clk_freq(smu, SMU_FCLK, &now);
if (ret) { if (ret) {
pr_err("Attempt to get current fclk Failed!"); pr_err("Attempt to get current fclk Failed!");
return ret; return ret;
...@@ -1028,7 +1028,7 @@ static int vega20_print_clk_levels(struct smu_context *smu, ...@@ -1028,7 +1028,7 @@ static int vega20_print_clk_levels(struct smu_context *smu,
break; break;
case SMU_DCEFCLK: case SMU_DCEFCLK:
ret = smu_get_current_clk_freq(smu, PPCLK_DCEFCLK, &now); ret = smu_get_current_clk_freq(smu, SMU_DCEFCLK, &now);
if (ret) { if (ret) {
pr_err("Attempt to get current dcefclk Failed!"); pr_err("Attempt to get current dcefclk Failed!");
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment