Commit d78a1f08 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller

bnx2x: don't wait for Tx completion on recovery

When driver has hit a parity event, HW can no longer write to host memory.
As a result, Tx completions cannot be written to the host SB memory, and
waiting for Tx completions eventually timeout.
As driver is willing to delay as much as 1-2 seconds per Tx queue for its
draining and this delay is sequential, the time to recover might greatly
lengthen needlessly in case the recovery is done under multi-connection
traffic.
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 489ce5f4
...@@ -3042,8 +3042,12 @@ int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode, bool keep_link) ...@@ -3042,8 +3042,12 @@ int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode, bool keep_link)
bnx2x_save_statistics(bp); bnx2x_save_statistics(bp);
} }
/* wait till consumers catch up with producers in all queues */ /* wait till consumers catch up with producers in all queues.
bnx2x_drain_tx_queues(bp); * If we're recovering, FW can't write to host so no reason
* to wait for the queues to complete all Tx.
*/
if (unload_mode != UNLOAD_RECOVERY)
bnx2x_drain_tx_queues(bp);
/* if VF indicate to PF this function is going down (PF will delete sp /* if VF indicate to PF this function is going down (PF will delete sp
* elements and clear initializations * elements and clear initializations
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment